Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset: hasMetaData must be convert to bool in Dao #17027

Merged
merged 1 commit into from
May 17, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented May 8, 2024

Execute codeception with added missing strict_types declarations (See #15065)

In Asset.php line 1390:
                                                                                                                                                                      
  [TypeError]                                                                                                                                                         
  Pimcore\Model\Asset::setHasMetaData(): Argument #1 ($hasMetaData) must be of type bool, int given, called in /var/www/html/lib/Model/AbstractModel.php on line 187 
  
Exception trace:
  at /var/www/html/models/Asset.php:1390
 Pimcore\Model\Asset->setHasMetaData() at /var/www/html/lib/Model/AbstractModel.php:187
 Pimcore\Model\AbstractModel->setValue() at /var/www/html/lib/Model/AbstractModel.php:171
 Pimcore\Model\AbstractModel->setValues() at /var/www/html/lib/Model/Dao/DaoTrait.php:43
 Pimcore\Model\Dao\AbstractDao->assignVariablesToModel() at /var/www/html/models/Asset/Dao.php:55
 Pimcore\Model\Asset\Dao->getById() at /var/www/html/models/Asset.php:278
 Pimcore\Model\Asset::getById() at /var/www/html/tests/Support/Util/TestHelper.php:747
 Pimcore\Tests\Support\Util\TestHelper::cleanUp() at /var/www/html/tests/Support/Helper/AbstractDefinitionHelper.php:52
 Pimcore\Tests\Support\Helper\AbstractDefinitionHelper->_afterSuite() at /var/www/html/vendor/codeception/codeception/src/Codeception/Subscriber/Module.php:59
 Codeception\Subscriber\Module->afterSuite() at /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:220
 Symfony\Component\EventDispatcher\EventDispatcher->callListeners() at /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:56
 Symfony\Component\EventDispatcher\EventDispatcher->dispatch() at /var/www/html/vendor/codeception/codeception/src/Codeception/SuiteManager.php:153
 Codeception\SuiteManager->run() at /var/www/html/vendor/codeception/codeception/src/Codeception/Codecept.php:260
 Codeception\Codecept->runSuite() at /var/www/html/vendor/codeception/codeception/src/Codeception/Codecept.php:216
 Codeception\Codecept->run() at /var/www/html/vendor/codeception/codeception/src/Codeception/Command/Run.php:646
 Codeception\Command\Run->runSuites() at /var/www/html/vendor/codeception/codeception/src/Codeception/Command/Run.php:467
 Codeception\Command\Run->execute() at /var/www/html/vendor/symfony/console/Command/Command.php:326
 Symfony\Component\Console\Command\Command->run() at /var/www/html/vendor/symfony/console/Application.php:1078
 Symfony\Component\Console\Application->doRunCommand() at /var/www/html/vendor/symfony/console/Application.php:324
 Symfony\Component\Console\Application->doRun() at /var/www/html/vendor/symfony/console/Application.php:175
 Symfony\Component\Console\Application->run() at /var/www/html/vendor/codeception/codeception/src/Codeception/Application.php:112
 Codeception\Application->run() at /var/www/html/vendor/codeception/codeception/app.php:45
 {closure}() at /var/www/html/vendor/codeception/codeception/app.php:46
 require() at /var/www/html/vendor/codeception/codeception/codecept:7
 include() at /var/www/html/vendor/bin/codecept:119

Copy link

github-actions bot commented May 8, 2024

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@lukmzig lukmzig self-assigned this May 17, 2024
@lukmzig
Copy link
Contributor

lukmzig commented May 17, 2024

Thank you @blankse

@lukmzig lukmzig added this to the 11.2.4 milestone May 17, 2024
@lukmzig lukmzig merged commit a3b4955 into pimcore:11.2 May 17, 2024
18 checks passed
@blankse blankse deleted the asset_has_meta_data branch May 17, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants