Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractModel::__call() - Don't throw and log exceptions #17012

Open
wants to merge 3 commits into
base: 11.x
Choose a base branch
from

Conversation

blankse
Copy link
Contributor

@blankse blankse commented May 3, 2024

Changes in this pull request

See pimcore/newsletter-bundle#51
Here it was catched, but because of this many log entries was generated.

I think it makes not sense to throw and log an exception. Either catch and log or not catching and the user can catch it.

Copy link

github-actions bot commented May 3, 2024

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@blankse blankse changed the title AbstractModel::__call() - Not throw and log exceptions AbstractModel::__call() - Don't throw and log exceptions May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants