[Improvement]: Move grid data related functions to admin-ui-classic-bundle

[kingjia90]

Changes in this pull request

Resolves #15971
Requires pimcore/admin-ui-classic-bundle#457

[github-actions]

Review Checklist

• Target branch (11.1 for bug fixes, others 11.x)
• Tests (if it's testable code, there should be a test for it - get help)
• Docs (every functionality needs to be documented, see here)
• Migration incl. install.sql (e.g. if the database schema changes, ...)
• Upgrade notes (deprecations, important information, migration hints, ...)
• Label
• Milestone

[kingjia90]

The combination pimcore ^11.2 and admin ui ^1.4 seem it would work fine (test green) as pimcore/admin-ui-classic-bundle@27f998c
Just a little tricky to test on pimcore/pimcore as there are no hard requirement for which version of admin ui it should use, outside the platform version

[blankse]

@kingjia90 So it is not possible to use pimcore 11.2 with admin ui < 1.4? So I think you should add it to the conflict section in the composer.json

[kingjia90]

@blankse that's a nice idea, thank you!

[blankse]

Maybe we should also add the admin ui to the require-dev section to fix the phpstan tests? There are also many errors in the baseline because the bundle is missing.

[sonarcloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[markus-moser]

@kingjia90 Could you please resolve the conflicts?

[kingjia90]

@kingjia90 Could you please resolve the conflicts?

Done, more specifically the changes from #16806 and #17006 weren't merged there when i cut/pasted across repos at the time, but now are moved to pimcore/admin-ui-classic-bundle#457 accordingly

[markus-moser]

LGTM, we need to check the composer.json (see my comment)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud