feat: add slack refresh token function #98
Conversation
KazuumiN
commented
Apr 2, 2024
•
KazuumiN
commented
- Token rotation
- openid.connect.token
src/providers/slack.ts
Outdated
| idToken: result.id_token | ||
| idToken: result.id_token, | ||
| refreshToken: result.refresh_token ?? null, | ||
| accessTokenExpiresAt: typeof result.expires_in !== "undefined" && createDate(new TimeSpan(result.expires_in, "s")) || undefined |
There was a problem hiding this comment.
This line is quite strange, but I found that expires_in field didn't appeared when I didn't use token rotation...
There was a problem hiding this comment.
I think that's expected since without token exchange, the access token last indefinitely. Should be null instead of undefined tho
There was a problem hiding this comment.
Thanks. That makes sense.
If I understood correctly, I'll change like this.
| accessTokenExpiresAt: typeof result.expires_in !== "undefined" && createDate(new TimeSpan(result.expires_in, "s")) || undefined | |
| accessTokenExpiresAt: typeof result.expires_in !== "undefined" && createDate(new TimeSpan(result.expires_in, "s")) || null |
And in this case, should I also change the accessTokenExpiresAt field in Token type too? Since it doesn't accept null type.
Line 107 in 69afa38
There was a problem hiding this comment.
Didn't realize that! Yeah the type declaration should be updated to allow null
Co-authored-by: pilcrow <[email protected]>
.changesets/vnlwb.minor.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| ``` | |||
There was a problem hiding this comment.
You can remove the code fence :)
| expires_in?: number; | ||
| } | ||
|
|
||
| interface RefreshTokenResponseBody { |
There was a problem hiding this comment.
Does it not create a new refresh token?
Use the new refresh_token when you need to refresh the tokens once again.
