Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylance fixes #906

Merged
merged 95 commits into from
Jun 14, 2024
Merged

Pylance fixes #906

merged 95 commits into from
Jun 14, 2024

Conversation

dantownsend
Copy link
Member

Builds on the changes in PR #905

Similarly to Mypy, Pylance has become much stricter / more accurate over time. There are now quite a few minor type errors being reported by Pylance.

As VSCode is such a popular code editor it would be good to clean up most (if not all) of these minor errors.

I'm not sure how easy it is to add Pyright (which powers Pylance) as a linter to our CI, but will investigate.

@dantownsend dantownsend added this to In progress in Testing via automation Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: Patch coverage is 88.46154% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (70dac99) to head (6d8bc36).
Report is 3 commits behind head on master.

Files Patch % Lines
piccolo/table.py 54.54% 5 Missing ⚠️
piccolo/query/methods/select.py 66.66% 3 Missing ⚠️
piccolo/engine/cockroach.py 0.00% 2 Missing ⚠️
piccolo/engine/postgres.py 88.23% 2 Missing ⚠️
piccolo/engine/sqlite.py 84.61% 2 Missing ⚠️
piccolo/utils/encoding.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   89.27%   88.41%   -0.86%     
==========================================
  Files         114      114              
  Lines        8333     8383      +50     
==========================================
- Hits         7439     7412      -27     
- Misses        894      971      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend
Copy link
Member Author

This PR is insanely big - I'm going to break it down into smaller chunks, and merge those in (starting with any changes to test files).

@dantownsend dantownsend marked this pull request as ready for review June 14, 2024 10:18
@dantownsend dantownsend merged commit e1550b4 into master Jun 14, 2024
46 checks passed
Testing automation moved this from In progress to Done Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants