-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update teleporter.php to load an archive from the command line #2449
Update teleporter.php to load an archive from the command line #2449
Conversation
There are some errors reported by the __ I'll take care of fixing the PHPStan. |
SHould be fixed now, sorry about that. |
This should fix Once it's merged, please rebase your PR on |
I think it would be nice if you would also make changes to the We could have a option like |
My plan was to make this change, then the change to pihole, then document the new functionality. |
Please write the change to pihole and the documentation now. The former will allow for easier testing and the latter will prevent forgetting the documentation at all. |
pihole updates are in pi-hole/pi-hole#5064 |
Signed-off-by: Iain Henderson <[email protected]>
Signed-off-by: Iain Henderson <[email protected]>
faf2fa9
to
23bb0da
Compare
Signed-off-by: Iain Henderson <[email protected]>
Signed-off-by: Iain Henderson <[email protected]>
Signed-off-by: Iain Henderson <[email protected]>
Signed-off-by: Iain Henderson <[email protected]>
Co-authored-by: RD WebDesign <[email protected]> Signed-off-by: Iain Henderson <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Thanks for your PR and for keeping it up-to-date. However, things are moving fast and the development of Pi-hole v6 is "advanced" already. |
Signed-off-by: Iain Henderson <[email protected]>
Conflicts have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all your commits down.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Existing merge conflicts have not been addressed. This PR is considered abandoned. |
Are these changes worth pursuing or is the implementation in v6 sufficient? |
Personally, I think the changes in v6 are sufficient. As your code is |
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
This PR enhances teleporter.php so that it can restore an archive from the command line.
How does this PR accomplish the above?:
Two steps:
Link documentation PRs if any are needed to support this PR:
pi-hole/docs#818
By submitting this pull request, I confirm the following:
git rebase
)