Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid OS via IPv4 and IPv6 #5305

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Check for valid OS via IPv4 and IPv6 #5305

merged 1 commit into from
Nov 4, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jun 4, 2023

What does this PR aim to accomplish?:

Explicitly using IPv4 and IPv6 to fetch the list of supported OS.

Should fix #5303

See https://discourse.pi-hole.net/t/unsupported-os-detected-upon-pi-hole-update-w-ubuntu-22-04/63161/8

How does this PR accomplish the above?:

Doubles the code for IPv6


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/unsupported-os-detected-upon-pi-hole-update-w-ubuntu-22-04/63161/13

@yubiuser yubiuser marked this pull request as ready for review June 4, 2023 21:02
@yubiuser yubiuser requested a review from a team June 4, 2023 21:02
@dschaper
Copy link
Member

Please target development. This is something that can go out before v6.

@yubiuser
Copy link
Member Author

Backport PR #5399

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/possible-minor-issues-and-comments/65437/15

@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 11, 2023
@yubiuser yubiuser merged commit 758ace5 into development-v6 Nov 4, 2023
16 checks passed
@yubiuser yubiuser deleted the double_dig branch November 4, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pi-hole v6.0 PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants