VsDark v1.0 #104
VsDark v1.0 #104
Conversation
|
(I've done force-push to fix a wrong account usage, no change has been done here on the content) |
| "description": "VsCode Dark Theme like for PhpMyAdmin", | ||
| "author": "Miumo", | ||
| "url": "https://github.com/MrMiumo", | ||
| "supports": ["5.0", "5.1", "5.2"] |
There was a problem hiding this comment.
Are you sure about that ?
Did you test your theme ?
From what I see it should only be compatible with 4.9
There was a problem hiding this comment.
I've started from a theme made for 5.+ and tested it with 5.2, not any version in 4.x !
Why would it only be compatible with 4.9 ?
The theme is working well from what I have tested.
There was a problem hiding this comment.
I really doubt this because you have .php files and this is long dead 🤔
What theme did you use as an example ?
Here is an example of theme that uses the most modern theme methods: https://github.com/phpmyadmin/themes/tree/master/boodark
There was a problem hiding this comment.
Allright, I'll take a look at it. I've use the default theme found inside phpMyAdmin. I guess the php files that are in there are no longer use and I can remove them safely!
I am looking at it. Thank you for you for this feedbacks!
There was a problem hiding this comment.
Cool, maybe you did some upgrades without a cleanup of the old data :)
You can push a commit to remove them, I will continue my review right after
There was a problem hiding this comment.
Very cool, it looks better 💯
Did you try your theme on the 3 different versions you advertise ?
If I recall correctly, it's not possible in a easy way to have compatibility for 5.0 and 5.2
Bootstrap versions ...
There was a problem hiding this comment.
I'm really sorry to answer so late, I missed the notification 😓
I only tried with version 5.2. I kept 5.0 and 5.1 as they where in the theme I started from and so I thought these 3 versions worked the same. But with your message I guess it's not the case!
Do I only need to indicate the version(s) I tested the theme on or are there compatibility things?
There was a problem hiding this comment.
Do I only need to indicate the version(s) I tested the theme on or are there compatibility things?
The versions you indicate here will allow the theme to work on the stated phpMyAdmin versions, so it's pretty important.
You should only put the ones you tested as it quickly dives into specific changes for Bootstrap between versions
There was a problem hiding this comment.
@williamdes I want to create a theme for phpmyadmin, so what theme should I take as starter?
There was a problem hiding this comment.
The theme https://github.com/phpmyadmin/themes/tree/master/boodark is a very well maintained one
You can find more of the fine tooling here: https://github.com/adorade/boodark
I will leave it up to @adorade if they want to give some help on building themes using boodark as a template
Hi,
I've made a theme for PhpMyAdmin, inspired by the default VsCode dark theme (based on pmahome theme, edited to looks like VsCode).
I hope it will convince you, and I am ready to adapt some things if I've missed them 🙂