Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Query Generator criteria on column * #19167

Open
wants to merge 3 commits into
base: QA_5_2
Choose a base branch
from

Conversation

faissaloux
Copy link
Contributor

Before

When choosing * in the column we can't use it in condition. This generates a non-valid query.

Screenshot from 2024-05-15 16-45-48

To fix this issue I have added another select in the criteria area where we can choose the column (* not included) that we want the criteria to be applied on

After

Screenshot from 2024-05-15 16-50-52

@faissaloux faissaloux force-pushed the fix-query-diff-col-condition branch from 9190ec2 to cea3e2c Compare May 15, 2024 15:54
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.29%. Comparing base (1a781a0) to head (b572749).
Report is 6 commits behind head on QA_5_2.

Current head b572749 differs from pull request most recent head 1807f03

Please upload reports for the commit 1807f03 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             QA_5_2   #19167      +/-   ##
============================================
- Coverage     48.64%   48.29%   -0.36%     
+ Complexity    17015    16970      -45     
============================================
  Files           607      607              
  Lines         72326    62371    -9955     
============================================
- Hits          35183    30119    -5064     
+ Misses        37143    32252    -4891     
Flag Coverage Δ
dbase-extension 48.24% <ø> (-0.02%) ⬇️
recode-extension ?
unit-7.2-ubuntu-latest 48.19% <ø> (-1.13%) ⬇️
unit-7.3-ubuntu-latest ?
unit-7.4-ubuntu-latest ?
unit-8.1-ubuntu-latest ?
unit-8.2-ubuntu-latest ?
unit-8.3-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faissaloux faissaloux force-pushed the fix-query-diff-col-condition branch from b572749 to 93990c3 Compare May 15, 2024 22:38
Signed-off-by: faissaloux <[email protected]>
Signed-off-by: faissaloux <[email protected]>
@faissaloux faissaloux force-pushed the fix-query-diff-col-condition branch from 93990c3 to 1807f03 Compare May 27, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant