Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf-url-image-reader-phi-814 #968

Merged
merged 1 commit into from
May 20, 2024
Merged

pdf-url-image-reader-phi-814 #968

merged 1 commit into from
May 20, 2024

Conversation

ysolanky
Copy link
Contributor

No description provided.

@ysolanky ysolanky mentioned this pull request May 20, 2024
Closed
sridharaiyer
sridharaiyer approved these changes May 20, 2024
View reviewed changes
Copy link

@sridharaiyer sridharaiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked in my initial test of having 1 PDF, which I what I need for my use case! Good job! Thanks!

Maybe someone can try testing this with multiple PDFs with images and a hybrid combination of PDFs with images and ones with direct text.

@ashpreetbedi ashpreetbedi merged commit 565b500 into main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sridharaiyer sridharaiyer sridharaiyer approved these changes

@ashpreetbedi ashpreetbedi ashpreetbedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ysolanky @sridharaiyer @ashpreetbedi