Fix keyboard focus of rename method refactoring window #16835
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w is opened. There is something weird on SpTextInputFieldPresenter. In SpTextInputFieldPresenter>>takeKeyboardFocusWithoutSelecting the comments state "Unlike `takeKeyboardFocus` this method will not select the text inside." however SpTextInputFieldPresenter>>takeKeyboardFocus does not select by default, hence the additional selectAll in the implementation.
|
This is strange because I do not see any files changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16699 by setting the keyboard focus after the window is opened.
There is something weird on SpTextInputFieldPresenter.
In
SpTextInputFieldPresenter>>takeKeyboardFocusWithoutSelectingthe comments state"Unlike `takeKeyboardFocus` this method will not select the text inside."However
SpTextInputFieldPresenter>>takeKeyboardFocusdoes not select by default, hence the additional selectAll in the implementation.