Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up FFI usage of SDL2 #16798

Open
wants to merge 1 commit into
base: Pharo13
Choose a base branch
from

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Jun 24, 2024

  • Using a FFILibrary
  • Using FFILibraryFinders to find the libraries
  • Removing old plugin code
  • Removing old Surface plugin code

- Using a FFILibrary
- Using FFILibraryFinders to find the libraries
- Removing old plugin code
- Removing old Surface plugin code
@tesonep tesonep marked this pull request as ready for review June 24, 2024 09:36
@tesonep tesonep requested a review from guillep June 24, 2024 09:36
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@MarcusDenker
Copy link
Member

Full image buiild fails:

MetacelloNotification: Project: Microdown
MetacelloNotification: Project: WelcomeBrowser
SubscriptOutOfBounds: 1 in #[]
ByteArray(Object)>>errorSubscriptBounds:
ByteArray(Object)>>at:
ByteArray>>byteAt:
ZipReadStream(InflateStream)>>nextByte
ZipReadStream(InflateStream)>>nextBits:
ZipReadStream(InflateStream)>>getNextBlock
ZipReadStream(InflateStream)>>pastEndRead
ZipReadStream(InflateStream)>>next
ZipReadStream(InflateStream)>>next:into:startingAt:
[[ readDataRemaining > 0 ] whileTrue: [
		| chunkSize |
		chunkSize := 32768 min: readDataRemaining.
		buffer := decoder next: chunkSize into: buffer startingAt: 1.
		aStream next: chunkSize putAll: buffer startingAt: 1.
		readDataRemaining := readDataRemaining - chunkSize.
	]] in ZipFileMember>>uncompressDataTo: in Block: [[ readDataRemaining > 0 ] whileTrue: [...
FullBlockClosure(BlockClosure)>>on:do:
ZipFileMember>>uncompressDataTo:

@jecisc
Copy link
Member

jecisc commented Jun 24, 2024

Since it's a zip problem I relaunched the CI because sometimes this code produce random failure

@Ducasse
Copy link
Member

Ducasse commented Jun 25, 2024

SystemNotification: Loading StartupPreferences-tonel.1.mcz
SystemNotification: Loading PragmaCollector-tonel.1.mcz
SystemNotification: Loading System-FileRegistry-tonel.1.mcz
�[31m�[33m
*** Warning: Warning: Package UNKNOWN depends on the following classes:
  FileList
You must resolve these dependencies before you will be able to load these definitions: 
  FileList>>#fileInto:
  FileList>>#fileReaderServicesForFile:suffix:
  FileList>>#serviceFileIn
  FileList>>#services
  FileList>>#sourceFileSuffixes

�[0m�[0mSystemNotification: Loading MonticelloFileTree-Core-tonel.1.mcz
NewUndeclaredWarning: MCFileTreeAbstractReader>>packageProperties (STON is Undeclared)
NewUndeclaredWarning: MCFileTreeStCypressReader>>addClassAndMethodDefinitionsFromEntry: (STON is Undeclared)
NewUndeclaredWarning: MCFileTreeStCypressReader>>addClassAndMethodDefinitionsFromEntry: (STON is Undeclared)
NewUndeclaredWarning: MCFileTreeStCypressReader>>addExtensionClassAndMethodDefinitionsFromEntry: (STON is Undeclared)
NewUndeclaredWarning: MCFileTreeStCypressReader>>addExtensionClassAndMethodDefinitionsFromEntry: (STON is Undeclared)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants