-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix + Tests for Pharo12 bug for issue #16702 #16736
Open
bouraqadi
wants to merge
1
commit into
pharo-project:Pharo12
Choose a base branch
from
bouraqadi:16702-Trait-class-side-methods-sometimes-not-installed-on-user-classes-Bug-in-P12--P11
base: Pharo12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix + Tests for Pharo12 bug for issue #16702 #16736
bouraqadi
wants to merge
1
commit into
pharo-project:Pharo12
from
bouraqadi:16702-Trait-class-side-methods-sometimes-not-installed-on-user-classes-Bug-in-P12--P11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods sometimes not installed on user classes
Thanks so much @bouraqadi |
Hi Pableo,
The answer is yes. The fix should be applied to P13 too.
I just tried on P13.
Tests alone fail.
With the fix, they turn green.
Thanks,
Noury
…On Jun 3 2024, at 9:49 am, Pablo Tesone ***@***.***> wrote:
Thanks so much @bouraqadi (https://github.com/bouraqadi)
Do you know if this change should be done also in P13?
Thanks again
—
Reply to this email directly, view it on GitHub (#16736 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADKJD7MB4QQ4XLQMNL4TCTZFQNZZAVCNFSM6AAAAABISWWDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUGUYDMNRQGA).
You are receiving this because you were mentioned.
|
Great, thanks. |
The failing test are related |
Yes. The one I provide with the fix. And they pass once the fix is installed.
…On Jun 3 2024, at 4:05 pm, Pablo Tesone ***@***.***> wrote:
The failing test are related
—
Reply to this email directly, view it on GitHub (#16736 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADKJD3G3T56YHM6ULKSAALZFRZ23AVCNFSM6AAAAABISWWDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGI4TENRUGE).
You are receiving this because you were mentioned.
|
BTW, I did a PR backporting the fix and the tests to Pharo 11.
#16737
…On Jun 3 2024, at 4:10 pm, Noury Bouraqadi ***@***.***> wrote:
Yes. The one I provide with the fix. And they pass once the fix is installed.
On Jun 3 2024, at 4:05 pm, Pablo Tesone ***@***.***> wrote:
>
>
> The failing test are related
> —
> Reply to this email directly, view it on GitHub (#16736 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AADKJD3G3T56YHM6ULKSAALZFRZ23AVCNFSM6AAAAABISWWDIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGI4TENRUGE).
> You are receiving this because you were mentioned.
>
|
I do not understand why the test are failing. This PR contains both the tests and the fix, or not?
|
Strange. It should pass for P12. |
This PR is for Pharo12 and the test fail. Traits tests. |
Fixed in PR #16823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trait class side methods sometimes not installed on user classes