Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] RBCopy broken tests #16850

Closed
Ducasse opened this issue Jul 1, 2024 · 5 comments
Closed

[CI] RBCopy broken tests #16850

Ducasse opened this issue Jul 1, 2024 · 5 comments
Assignees

Comments

@Ducasse
Copy link
Member

Ducasse commented Jul 1, 2024

Hi hernan can you have a look at the following tests:

Unix64.Refactoring.Transformations.Tests.RBCopyPackageParametrizedTest.testCopyPackageAndChangesCopyReferences(#rbClass->RBCopyPackageRefactoring)
 Unix64.Refactoring.Transformations.Tests.RBCopyPackageParametrizedTest.testCopyPackageWithParameters(#rbClass->RBCopyPackageRefactoring)

 Unix64.Refactoring.UI.Tests.ReDuplicateClassDriverTest.testDuplicateClass
@MarcusDenker MarcusDenker changed the title RBCopy broken tests [CI] RBCopy broken tests Jul 2, 2024
@MarcusDenker
Copy link
Member

The revert would fix them: #16849

@MarcusDenker
Copy link
Member

I merged the revert, we need to get the tests green and there are more failing tests due to PRs that we can not even revert anymore as they are from 2 weeks ago. Reverting this means we can focus on those.

@hernanmd
Copy link
Contributor

hernanmd commented Jul 2, 2024

I merged the revert, we need to get the tests green and there are more failing tests due to PRs that we can not even revert anymore as they are from 2 weeks ago. Reverting this means we can focus on those.

I was working on this issue but didn't know it was so urgent. I just pushed a PR with the fix in #16853

@MarcusDenker
Copy link
Member

So now we have a conflict.

@hernanmd
Copy link
Contributor

hernanmd commented Jul 2, 2024

So now we have a conflict.

Yes, now it seems I had to manually resolve the conflict :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants