Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] failing test: testNoUnusedInstanceVariablesLeft #16824

Open
MarcusDenker opened this issue Jun 28, 2024 · 3 comments
Open

[CI] failing test: testNoUnusedInstanceVariablesLeft #16824

MarcusDenker opened this issue Jun 28, 2024 · 3 comments

Comments

@MarcusDenker
Copy link
Member

Bug description
testNoUnusedInstanceVariablesLeft is failing:

the following classes have unused instance variables:

ReClassForGeneratingEqualAndHash ReClassForGeneratingPrintOn OupsDummyDebuggerSystem ReClassForGeneratingEqualAndHashExistingImplementors
@MarcusDenker
Copy link
Member Author

Some where introduced by #16786, but we can not revert it anymore as there where too many things merged after.

So we have to fix it.

@MarcusDenker
Copy link
Member Author

ReClassForGeneratingEqualAndHash is test data, so we can not just remove the ivar

@hernanmd
Copy link
Contributor

hernanmd commented Jul 3, 2024

Please notice there is a PR that fixes the issue for the Refactoring packages here: https://github.com/pharo-project/pharo/pull/16853/files#diff-78c29fe49f6e8997db820120f064e9b206e666f6281d26f883d491e1d8d926f3

Another PR should address the OupsDummyDebuggerSystem one.

GitHub
Fix a couple of tests failing, reported in #16850, due to missing support to pre-configure refactorings for test purposes. Also configured missing mocks for the preview presenter. Fix also for #16825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants