Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactorings] Rename refactoring should focus the input field #16699

Open
jecisc opened this issue May 27, 2024 · 0 comments · May be fixed by #16835
Open

[Refactorings] Rename refactoring should focus the input field #16699

jecisc opened this issue May 27, 2024 · 0 comments · May be fixed by #16835
Labels
Type: Enhancement

Comments

@jecisc
Copy link
Member

jecisc commented May 27, 2024

Today I had to rename multiple methods to change the end of the name. I was using my keyboard to navigate Calypso and I would have liked to be able to rename the methods using my keyboard also but the focus was not user friendly.

I would expect the UI to open focusing the input field with the name of the method and I would like to be able to press enter and have the refactoring applied.
Inao0 pushed a commit to Inao0/pharo that referenced this issue Jun 28, 2024
Fix pharo-project#16699 by setting the keyboard focus after the windo…
8ee9f5b 
…w is opened.

There is something weird on SpTextInputFieldPresenter.
In SpTextInputFieldPresenter>>takeKeyboardFocusWithoutSelecting the comments state "Unlike `takeKeyboardFocus` this method will not select the text inside." however SpTextInputFieldPresenter>>takeKeyboardFocus does not select by default, hence the additional selectAll in the implementation.
@Inao0 Inao0 linked a pull request Jun 28, 2024 that will close this issue
Open
Inao0 pushed a commit to Inao0/pharo that referenced this issue Jun 29, 2024
See previous commit message. Fix pharo-project#16699
6cb44cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix keyboard focus of rename method refactoring window Inao0/pharo
1 participant
@jecisc