#142 - Support Redis Cluster #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added RedisCluster.php adapter
niden
requested changes
Apr 11, 2024
RedisCluster Adapter to inherit from Redis Adapter
Codacy post-static analysis adjustments
RedisCluster as Cache adapter
- docker cluster configuration - common Cache/Adapter/Redis RedisCluster tests - improvements in class inheritance configuration separation - old issue with consts not set in RedisCluster phpredis library worked around
- revert unnecesary formatting update from Redis.php - added missing newline for RedisCluster.php
adjust to codestyle
remove duplicated methods
remove obsolete imports
update Cache\Redis integration tests
update integration tests for Storage\Adapter to include testing RedisCluster adapter
|
niden
requested changes
May 2, 2024
| * } $options | ||
| * @throws SupportException | ||
| */ | ||
| public function __construct(SerializerFactory $factory, array $options = []) |
There was a problem hiding this comment.
This is not really necessary. The parent will be called either way.
niden
approved these changes
Jun 16, 2024
|
Than kyou @yergo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following:
Small description of change:
Added Storage\Adapter\RedisCluster for \RedisCluster to be compatible with framework.