Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alternative WAL segment sizes for PostgreSQL before 11 #2303

Open
wants to merge 4 commits into
base: integration
Choose a base branch
from

Conversation

KnightMurloc
Copy link
Contributor

@KnightMurloc KnightMurloc commented Mar 15, 2024

For PostgreSQL before 11, alternate WAL segment sizes can be selected only at compile-time. While compile-time settings are generally not well tested by core, some established forks such as Greenplum use them.
This patch removes the limitation of the default WAL segment size for PostgreSQL before 11.

@KnightMurloc
Copy link
Contributor Author

@dwsteele, you asked to make PRs from personal forks, not from the company's one. My team lead says that we cannot use personal forks, because there is a possibility of losing access to the PR in case the author of the PR is unavailable (has resigned, gone on vacation, on sick leave, etc.). Therefore, the company policy requires making PRs from the corporate fork. As a solution, if you want to make cosmetic changes, you can form final commit with your changes in the integration branch, and then close the PR.

@dwsteele
Copy link
Member

I'm not too excited about adding an option for this. If we are going to let people bypass this then I think it makes more sense to simply remove the constraint at https://github.com/pgbackrest/pgbackrest/blob/release/2.50/src/postgres/interface.c#L176.

you asked to make PRs from personal forks, not from the company's one

You and your colleagues are making valuable contributions so I'm not going to make a big fuss. I still prefer to merge the commit rather than closing it so we'll just continue what we've been doing.

@KnightMurloc
Copy link
Contributor Author

That is, would you prefer the option without checking for Postgres < 11 that the size of the WAL segment is the default, leaving only the check that the value is valid?

@dwsteele
Copy link
Member

dwsteele commented Mar 18, 2024

That is, would you prefer the option without checking for Postgres < 11 that the size of the WAL segment is the default, leaving only the check that the value is valid?

I can't quite parse this sentence, but I think so? All versions <= 11 are EOL so I'm OK with just removing the constraint on the value being default, which should just mean removing that check and adjusting the test.

Before PostgreSQL 11, alternative WAL segment sizes can be selected at compile-time, for example, 64MB. While compile-time settings are generally not well tested by the core, some established forks, such as Greenplum, use them.
This patch adds a parameter that allows explicitly specify the expected size of the WAL segment. Which can be useful for backup forks whose base version of Postgres is less than 11.
For PostgreSQL before 11, alternate WAL segment sizes can be selected only at compile-time. While compile-time settings are generally not well tested by core, some established forks such as Greenplum use them.
This patch removes the limitation of the default WAL segment size for PostgreSQL before 11.
@KnightMurloc KnightMurloc changed the title Add a parameter to explicitly specify the size of the WAL segment. Allow alternative WAL segment sizes for PostgreSQL before 11 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants