Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.5.0 #45

Merged
merged 80 commits into from
Jun 12, 2023
Merged

Release v1.5.0 #45

merged 80 commits into from
Jun 12, 2023

Conversation

DylanYang0523
Copy link
Contributor

PR Reminders

  1. Contract: make sure the code follows our convention, ex: naming, explicit returns, etc.; if uncertain, discuss with others

  2. Test: make sure tests can cover most normal and edge cases; if not, open follow-up tickets. Also, look out for failed tests and fix them!

  3. CHANGELOG.md: update when external interfaces are changed

  4. Workflow:

    • Github: assign the pr to yourself; if pairing, can merge directly; else, assign someone to help review
    • Asana: assign the corresponding ticket to yourself and leave the pr link on it for easier follow-ups
    • Discord: if someone is mentioned in this pr, tag on Discord

DylanYang0523 and others added 30 commits April 6, 2023 15:48
@DylanYang0523
chore: add basic otc maker contracts, include interface and storage
2116af6
@DylanYang0523
feat: add OtcMaker contract, storage, interface and struct
cc4649a
@DylanYang0523
feat(OtcMaker): add setCaller and deposit functions
2538cec
@DylanYang0523
test(OtcMaker): setter test
3ebe2ca
@DylanYang0523
feat(OtcMaker): add perp setup
c03965d
@DylanYang0523
chore: adjust foundry toml
1df2be3
@twxia
fix: _create_UniswapV3Factory issue
d4d477e
@twxia
Merge pull request #40 from perpetual-protocol/feature/otc-maker-add-…
7a66221 
…perp-setup

Feature/otc maker add perp setup
@twxia
fix: deposit test
1802f8e
@twxia
feat: change deposit/withdraw/settters to owner only
3e465a2
@twxia
feat: added withdraw / withdrawToken methods
920a646
@twxia
feat: added _obtainSigner
7662e11
@twxia
feat: added isMarginSufficient method
b2872d8
@twxia
feat: update interface
3f0df70
@DylanYang0523
feat: add _requireMarginSufficient
8fb9b0a
@DylanYang0523
feat: add TestOtcMaker
7c7e4aa
@DylanYang0523
feat: update OpenPositionForParams struct
56c1a5f
@DylanYang0523
test(OtcMaker): obtainSigner
386a81e
@DylanYang0523
feat(OtcMaker): implemented openPositionFor
e9e620c
@twxia
feat: migrate clearingHouse.openPositionFor to limitOrderBook's
c3fcad4
@twxia
fix: test
9cc9172
@twxia
chore: remove unused test
edf888c
@twxia
chore: refine code
79d6605
@twxia
test: openPositionFor() happy case added
2acc53e
@twxia
chore: update foundry test script
41021e5
@twxia
Merge pull request #42 from perpetual-protocol/feature/otc-maker-open…
129ca27 
…PositionFor

Feature/otc maker open position for
@DylanYang0523
feat(OtcMaker): remove unused event and struct
bfd6498
@DylanYang0523
chore: add comments for how to resolving getOrderHash test failed issue
ca3bf04
@DylanYang0523
chore(LimitOrderBook): avoid to use tx.origin
3705423
@DylanYang0523
chore(OtcMaker): add comments and remove unuesed variables
6f01347
DylanYang0523 and others added 22 commits May 25, 2023 22:18
@DylanYang0523
chore: update IOtcMakerStruct license from GPL-2 to GPL-3
c15caf5
@DylanYang0523
chore: update emit event order in OtcMaker's setter funcions
dcbc31d
@DylanYang0523
chore: move emit event to the end of the setter function
b00f598
@DylanYang0523
feat(otcMaker): OpenPositionFor will return exchangedPositionSize & e…
b397f25 
…xchangedPositionNotional
@DylanYang0523
test: fix OtcMaker.getter
e454078
@DylanYang0523
test: fix OtcMaker.openPositionFor
af6352b
@DylanYang0523
chore: renamed variable in LimitOrderBook, from enable to isEnabled
f72880d
@DylanYang0523
test: renamed files, followed PERP test file naming convention
7d59181
@DylanYang0523
feat: add OtcMakerOrder type into LimitOrderBook
6f45801
@CheshireCatNick
test: otc order type
050ad3a
@CheshireCatNick
chore: fix lint
8e756fd
@DylanYang0523
doc: add NatSpec for OtcMaker.sol
7e06205
@DylanYang0523
doc: update CHANGELOG.md
18040c2
@DylanYang0523
doc: reorganized IOtcMaker NatSpec
6e044b8
@DylanYang0523
feat: grab mmRatio from CH config instead of using 62500 hardcode
bbd7268
@DylanYang0523
fix: IERC20Upgradable import path of OtcMaker
2c8c2c7
@DylanYang0523
chore: removed _ variable prefix to keep consistency
bfbd2e9
@DylanYang0523
feat: removed OpenPositionForResponse from IOtcMakerStruct
f72bbb2
@DylanYang0523
Merge branch 'feat/internal-audit-1.5.0' into feat/support-otc-order-…
b206c87 
…type
@DylanYang0523
chore: removed names of return params
1eccb3d
@CheshireCatNick
fix: commend add return value
3fa62ff
@CheshireCatNick
Merge pull request #51 from perpetual-protocol/feat/support-otc-order…
dc7e253 
…-type

feat: add OtcMakerOrder type into LimitOrderBook
@tailingchen tailingchen marked this pull request as ready for review May 31, 2023 07:02
@DylanYang0523 DylanYang0523 merged commit c44f40a into main Jun 12, 2023
7 checks passed
@DylanYang0523 DylanYang0523 deleted the release/v1.5.0 branch June 12, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tailingchen tailingchen tailingchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DylanYang0523 @tailingchen @twxia @CheshireCatNick