Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12913 Migrate api endpoints to REST #2880

Open
wants to merge 87 commits into
base: v3-api-breaking-changes
Choose a base branch
from

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Mar 6, 2024

PMM-12913

Link to the Feature Build: SUBMODULES-3581
Link to the FB integrated with frontend: SUBMODULES-3624

With this PR we migrate our API endpoints to make them more RESTful.

You can track the spec file here.

NOTE: currently the Main/Checks workflow is failing because of this issue, which is unrelated to this PR.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 254 lines in your changes missing coverage. Please review.

Project coverage is 44.49%. Comparing base (108972f) to head (6913e01).

Files Patch % Lines
admin/commands/management/add_mysql.go 0.00% 38 Missing ⚠️
admin/commands/management/add_postgresql.go 0.00% 38 Missing ⚠️
admin/commands/management/add_mongodb.go 0.00% 36 Missing ⚠️
...min/commands/management/add_external_serverless.go 0.00% 31 Missing ⚠️
admin/commands/management/add_proxysql.go 0.00% 26 Missing ⚠️
admin/commands/management/add_external.go 0.00% 21 Missing ⚠️
admin/commands/management/add_haproxy.go 0.00% 19 Missing ⚠️
admin/commands/management/remove.go 0.00% 19 Missing ⚠️
admin/commands/inventory/list_agents.go 0.00% 5 Missing ⚠️
admin/commands/inventory/list_services.go 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@                     Coverage Diff                     @@
##           v3-api-breaking-changes    #2880      +/-   ##
===========================================================
- Coverage                    44.68%   44.49%   -0.19%     
===========================================================
  Files                          362      360       -2     
  Lines                        35377    35500     +123     
===========================================================
- Hits                         15808    15797      -11     
- Misses                       17957    18097     +140     
+ Partials                      1612     1606       -6     
Flag Coverage Δ
admin 11.46% <0.00%> (-0.05%) ⬇️
agent 52.60% <ø> (-0.14%) ⬇️
managed 46.69% <ø> (-0.25%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff force-pushed the PMM-12913-migrate-api-endpoints-to-restful branch from bbc5ec3 to 559c7f3 Compare March 11, 2024 12:00
@ademidoff ademidoff changed the title PMM-12913 migrate api endpoints to restful PMM-12913 Migrate api endpoints to restful Mar 12, 2024
@ademidoff ademidoff force-pushed the PMM-12913-migrate-api-endpoints-to-restful branch from 8c53f02 to a314087 Compare March 19, 2024 11:23
api/MIGRATION_EXAMPLES.md Outdated Show resolved Hide resolved
api/MIGRATION_EXAMPLES.md Outdated Show resolved Hide resolved
api/qan/v1/collector.proto Show resolved Hide resolved
@ademidoff ademidoff force-pushed the PMM-12913-migrate-api-endpoints-to-restful branch from 3a6ab0f to 51589a0 Compare June 3, 2024 12:09
@ademidoff ademidoff force-pushed the PMM-12913-migrate-api-endpoints-to-restful branch 5 times, most recently from 18368b6 to cbe7f14 Compare June 8, 2024 19:09
@ademidoff ademidoff force-pushed the PMM-12913-migrate-api-endpoints-to-restful branch from cbe7f14 to 6913e01 Compare June 9, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants