Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TDB-20] With checkpoint disabled, closing FT file still rotates header. #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jun-Yuan
Copy link
Contributor

jenkin: https://jenkins.percona.com/view/TokuDB/job/PerconaFT-param/120/
[Updated the comments and formats from the last PR.]

     This is an attempt based on @BohuTang's patch
         https://github.com/percona/PerconaFT/pull/331

     in particular, the ctest mostly comes from his with minor updates.

     Summary:
         1) The issue is real.
         2) @Bohu's patch works for mediating the issue but somewhat introduces
            a ft leak that the ft with ref=0 may be left until next open/close or
            checkpoint.
         3) If ft_close should be held off upon a backup, then it simply means
            a backup should hold a ref to the ft and responsible for closing ft up
            if it is the last one to hold it, like any other possible referencer.
            including the checkpoint, the txn and ft handlers.
         4) mtr test contributed by @BohuTang still passes. (in a different PS PR).

         [Updated the comments and formats from the last PR.]

         This is an attempt based on @BohuTANG's patch
             percona#331

         in particular, the ctest mostly comes from his with minor updates.

         Summary:
             1) The issue is real.
             2) @bohu's patch works for mediating the issue but somewhat introduces
                a ft leak that the ft with ref=0 may be left until next open/close or
                checkpoint.
             3) If ft_close should be held off upon a backup, then it simply means
                a backup should hold a ref to the ft and responsible for closing ft up
                if it is the last one to hold it, like any other possible referencer.
                including the checkpoint, the txn and ft handlers.
             4) mtr test contributed by @BohuTANG still passes. (in a different PS PR).
@george-lorch george-lorch self-requested a review March 29, 2018 21:35
@BohuTANG
Copy link
Contributor

BohuTANG commented Nov 2, 2018

Hello,

Any updates regarding this?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants