[TDB-28-25] try_again_after_handling_write_error checks only for EINTR and ENOSPC & ubuntu-yakkety-64bit fails for PerconaFT-param tests #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jun-Yuan
changed the title
…R and ENOSPC &
ubuntu-yakkety-64bit fails for PerconaFT-param tests
TDB-25: ubuntu-yakkety-64bit fails for PerconaFT-param tests
Updated CMakeList to not link againt jemalloc.a
TDB-28 : try_again_after_handling_write_error checks only for EINTR and ENOSPC
- Added some structured error logging during node, ft header/descriptor serialization
and writing to the log file.
- The error logging contains the file name, the calling function name and a bit of
background information such as if it is a node serialization, whether the root
cause is checkpoint or eviction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Updated] I tried to format the code using clang-format. Let me know if there is anything else I can improve. Thanks
I know I definitely have some formating issues. I would like to know what docu I can look at for our standard formatting? I also figured an early review is probably going to help me catch early what information I might have missed in the error logging code. Thanks :)
Jenkin link: http://jenkins.percona.com/view/TokuDB/job/PerconaFT-param/95/
and after updates
http://jenkins.percona.com/view/TokuDB/job/PerconaFT-param/98/