Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling client.logout() Exception gracefully with optional chaining #2447

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Handling client.logout() Exception gracefully with optional chaining #2447

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b8dd7e7
Added Optional Chaining to Avoid Breaking The Code
ayushmourya Aug 27, 2023
ad4ef76
Added Optional Chaining to Avoid Breaking Code
ayushmourya Aug 27, 2023
869e6de
Updated code to handle all node version
ayushmourya Aug 28, 2023
34df2e2
Merge branch 'main' into main
ayushmourya Sep 22, 2023
ddb4142
Merge branch 'main' into main
alechkos Dec 1, 2023
cba79e5
Merge branch 'main' into main
alechkos Dec 7, 2023
7cbfaa6
Merge branch 'main' into main
alechkos Dec 12, 2023
1f2da17
Merge branch 'main' into main
alechkos Dec 22, 2023
aaa7334
Merge branch 'main' into main
alechkos Jan 2, 2024
7c18e0e
Merge branch 'main' into main
alechkos Jan 11, 2024
d052577
Merge branch 'main' into main
alechkos Jan 14, 2024
e2be6f3
Merge branch 'main' into main
alechkos Jan 24, 2024
0400c83
Merge branch 'main' into main
alechkos Apr 30, 2024
ce0833c
Merge branch 'main' into main
shirser121 May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,9 @@ class Client extends EventEmitter {
*/
async logout() {
await this.pupPage.evaluate(() => {
return window.Store.AppState.logout();
if (window.Store && window.Store.AppState && typeof window.Store.AppState.logout === 'function') {
ayushmourya marked this conversation as resolved.
Show resolved Hide resolved
return window.Store.AppState.logout();
}
});
await this.pupBrowser.close();

Expand Down Expand Up @@ -1717,4 +1719,4 @@ class Client extends EventEmitter {
}
}

module.exports = Client;
module.exports = Client;