allow @ in identifiers #947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identifiers can contain the @ symbol, a typical example is ``` put @resources << /ColorSpace @pgfcolorspaces >> ``` as found in documents created with LaTeX package pgf and colorspaces. At the moment a pdf containing the above will trigger an error: ``` pdfminer.psparser.PSSyntaxError: Invalid dictionary construct: [/'ColorSpace', /b'@', /b'pgfcolorspaces'] ``` since @ is parsed as separate token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifiers can contain the @ symbol, a typical example is
as found in documents created with LaTeX package pgf and colorspaces.
At the moment a pdf containing the above will trigger an error:
since @ is parsed as separate token.
The PR was tested against about 20 different PDf papers from the arXiv corpus.
Checklist