Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Clean up Debug formatting of meta::Visual #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zombiepigdragon
Copy link

This removes the often large and unreadable Debug formatting for the affected type (a raw [u8] dump for an embedded image file), and replaces the output for data with a manually-formatted type that only shows the data's size. An alternative would be using a wrapper type for Box<u8> that implements this manual debug format on its own, avoiding the possible maintenance burden this PR could have and being reusable for other blob-like data in Symphonia, but this was not chosen as it would likely become a breaking change for relatively little benefit.

@dedobbin
Copy link
Contributor

dedobbin commented Jan 9, 2024

I can imagine there are situations where you want to see the data, but you can always just print the .data member. So yeah makes sense and lgtm

@abique
Copy link
Contributor

abique commented Feb 6, 2024

This PR looks good to me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants