Fix "MSISDN invalid" error #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the values of the arguments `from` and `to` (that must be a Vodacom phone number) are in `841234567` format as described in the documentation, you receive an `MSISDN invalid` error. The values of these properties must start with the country code `258` so that the error mentioned above does not occur.
thatfiredev
suggested changes
Dec 25, 2020
There was a problem hiding this comment.
@callebdev Thanks for finding this and coming up with a PR.
The most elegant way to fix it would be to use RegEx, but this workaround should work for now.
I just left a few comments that should be addressed before merging it:
| @@ -72,7 +72,11 @@ public Builder amount(double amount) { | |||
| } | |||
|
|
|||
| public Builder from(String from) { | |||
| this.from = from; | |||
| if (from.length() == 9) { | |||
There was a problem hiding this comment.
Checking the string's length sounds a bit hacky. Maybe we should check if the string starts with "258" instead?
| @@ -72,7 +72,11 @@ public Builder amount(double amount) { | |||
| } | |||
|
|
|||
| public Builder from(String from) { | |||
| this.from = from; | |||
| if (from.length() == 9) { | |||
| this.from = 258 + from; | |||
There was a problem hiding this comment.
Since this field is a String, let's use a String literal here
Suggested change
| this.from = 258 + from; | |
| this.from = "258" + from; |
Comment on lines
+94
to
+96
| if (to.length() == 9) { | ||
| this.to = 258 + to; | ||
| } else { |
There was a problem hiding this comment.
The 2 comments I left above also apply here.
|
@rosariopfernandes Thank you very much for leaving this code review. I will make the proposed changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #7
The values of
toandfrommust start with the country code258so that the error does not occur.With the current changes:
If:
841234567is passed as the argument offromorto, its value will be258841234567;258841234567is passed as the argument offromorto, its value will continue being258841234567;Thus, if the phone number is valid, regardless of whether its format is
258841234567or841234567, the MSISDN error will not occur.