Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting 404 for empty input #770

Open
Illusion47586 opened this issue Apr 4, 2023 · 2 comments · May be fixed by #777
Open

Getting 404 for empty input #770

Illusion47586 opened this issue Apr 4, 2023 · 2 comments · May be fixed by #777
Labels
bug good first issue

Comments

@Illusion47586
Copy link

Describe the bug
It looks like it is expected behaviour but I don't think we should allow an empty input call from the frontend.

To Reproduce
image
Don't type anything in the search box and press enter.
image
It takes you to https://bundlephobia.com/package which gives 404.

Expected behavior
I believe we should just do nothing when the input is empty.

Let me know if the suggested fix is good and I can make a relevant PR for the same.
@pastelsky
Copy link
Owner

Makes sense — the fix should be quite simple, so marking this as a good first issue.

@upteran upteran linked a pull request Apr 19, 2023 that will close this issue
Open
@upteran
Copy link

upteran commented Apr 19, 2023

Hi, I've sent PR, check pls and if need some changes, I'll update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] autocomplete empty input request upteran/bundlephobia
3 participants
@pastelsky @upteran @Illusion47586