Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new control request to set wifi creds #739

Closed
wants to merge 3 commits into from

Conversation

keeramis
Copy link
Contributor

Description

Device-OS added a new control request to set network credentials without needing for a connection attempt. This PR adds support to use this control request to configure wifi network. If device is of device-os version which does not support this control request (which is 6.x TBD), wifi is configured via serial commands

How to Test

  1. Flash your wifi devices with Add set credentials usb request device-os#2763
  2. Connect this CLI to this particle-usb PR Support to set network credentials via control request particle-usb#103
  3. Most important! Correct this line in this PR to always use control requests - https://github.com/particle-iot/particle-cli/compare/feature/wifi-configuration?expand=1#diff-cd875ddf040ba04907a08a3fd03ef7fa0039f29267b30aca435178386162ec24R538
  4. Run npm start -- serial wifi

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero
Copy link
Contributor

@keeramis I was checking particle-usb and saw that setWifiCredentials function was removed so this PR should be closed right?

@keeramis
Copy link
Contributor Author

@hugomontero Thanks for taking a look! I am temporarily closing this PR because of the new changes scoping out here. https://www.notion.so/particle/CLI-Improved-WiFi-Configuration-8a2ee199e4484b428e0ee0c9b26d219a

@monkbroc monkbroc closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants