(#400) RetryLater fail to send message #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change SubscriptionExceptionMiddleware to use the client's RabbitMQ username instead of the user_id of the message that caused the exception when publishing to the default error exchange. * Change RetryLaterMiddleware to use the client's RabbitMQ username instead of the user_id of the message that caused the exception when publishing to the retry exchange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change SubscriptionExceptionMiddleware to use the client's RabbitMQ
username instead of the user_id of the message that caused the
exception when publishing to the default error exchange.
Change RetryLaterMiddleware to use the client's RabbitMQ
username instead of the user_id of the message that caused the
exception when publishing to the retry exchange.
Description
When republishing a message after an exception to either the default error exchange or retry exchange the relevant middleware uses the user_id of the incoming message that caused the exception. If the user_id of that message is not the same as the consumer's login RabbitMQ will reject the message and close the connection.
This commit will override the user_id of the message properties just before re-publishing it so that RabbitMQ will accept it.
Check List
stablebranch.