feat: replace empty response body with 204 status code

paralect · Jan 29, 2024 · 715c644 · 715c644
1 parent 77c8146
commit 715c644
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 11 deletions.
diff --git a/template/apps/api/src/resources/account/actions/forgot-password.ts b/template/apps/api/src/resources/account/actions/forgot-password.ts
@@ -22,7 +22,7 @@ interface ValidatedData extends z.infer<typeof schema> {
 async function validator(ctx: AppKoaContext<ValidatedData>, next: Next) {
  const user = await userService.findOne({ email: ctx.validatedData.email });
 
- if (!user) return ctx.body = {};
+ if (!user) return ctx.status = 204;
 
  ctx.validatedData.user = user;
  await next();
@@ -53,7 +53,7 @@ async function handler(ctx: AppKoaContext<ValidatedData>) {
  },
  });
 
- ctx.body = {};
+ ctx.status = 204;
 }
 
 export default (router: AppRouter) => {

diff --git a/template/apps/api/src/resources/account/actions/resend-email.ts b/template/apps/api/src/resources/account/actions/resend-email.ts
@@ -24,7 +24,7 @@ async function validator(ctx: AppKoaContext<ValidatedData>, next: Next) {
 
  const user = await userService.findOne({ email });
 
- if (!user) return ctx.body = {};
+ if (!user) return ctx.status = 204;
 
  ctx.validatedData.user = user;
  await next();
@@ -50,7 +50,7 @@ async function handler(ctx: AppKoaContext<ValidatedData>) {
  }),
  ]);
 
- ctx.body = {};
+ ctx.status = 204;
 }
 
 export default (router: AppRouter) => {

diff --git a/template/apps/api/src/resources/account/actions/reset-password.ts b/template/apps/api/src/resources/account/actions/reset-password.ts
@@ -22,7 +22,7 @@ async function validator(ctx: AppKoaContext<ValidatedData>, next: Next) {
 
  const user = await userService.findOne({ resetPasswordToken: token });
 
- if (!user) return ctx.body = {};
+ if (!user) return ctx.status = 204;
 
  ctx.validatedData.user = user;
  await next();
@@ -38,7 +38,7 @@ async function handler(ctx: AppKoaContext<ValidatedData>) {
  resetPasswordToken: null,
  }));
 
- ctx.body = {};
+ ctx.status = 204;
 }
 
 export default (router: AppRouter) => {

diff --git a/template/apps/api/src/resources/account/actions/sign-out.ts b/template/apps/api/src/resources/account/actions/sign-out.ts
@@ -5,7 +5,7 @@ import { authService } from 'services';
 const handler = async (ctx: AppKoaContext) => {
  await authService.unsetTokens(ctx);
 
- ctx.body = {};
+ ctx.status = 204;
 };
 
 export default (router: AppRouter) => {

diff --git a/template/apps/api/src/resources/account/actions/sign-up.ts b/template/apps/api/src/resources/account/actions/sign-up.ts
@@ -70,7 +70,12 @@ async function handler(ctx: AppKoaContext<ValidatedData>) {
  },
  });
 
- ctx.body = config.IS_DEV ? { signupToken } : {};
+ if (config.IS_DEV) {
+ ctx.body = { signupToken };
+ return;
+ }
+
+ ctx.status = 204;
 }
 
 export default (router: AppRouter) => {

diff --git a/template/apps/api/src/resources/user/actions/remove.ts b/template/apps/api/src/resources/user/actions/remove.ts
@@ -20,7 +20,7 @@ async function validator(ctx: AppKoaContext<ValidatedData, Request>, next: Next)
 async function handler(ctx: AppKoaContext<ValidatedData, Request>) {
  await userService.deleteSoft({ _id: ctx.request.params.id });
 
- ctx.body = {};
+ ctx.status = 204;
 }
 
 export default (router: AppRouter) => {

diff --git a/template/apps/api/src/routes/middlewares/admin-auth.middleware.ts b/template/apps/api/src/routes/middlewares/admin-auth.middleware.ts
@@ -10,7 +10,6 @@ const adminAuth = (ctx: AppKoaContext, next: Next) => {
  }
 
  ctx.status = 401;
- ctx.body = {};
 
  return null;
 };

diff --git a/template/apps/api/src/routes/middlewares/auth.middleware.ts b/template/apps/api/src/routes/middlewares/auth.middleware.ts
@@ -6,7 +6,6 @@ const auth = (ctx: AppKoaContext, next: Next) => {
  }
 
  ctx.status = 401;
- ctx.body = {};
 
  return null;
 };