(refactor) Use BundleBuilder instead of hashmaps #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinv72
commented
May 14, 2024
| .push((old_storage.key.into(), old_storage.value)); | ||
|
|
||
| bundle_builder = bundle_builder | ||
| .state_storage(address, state_storage.entry(address).or_default().clone()); |
There was a problem hiding this comment.
I think we could probably avoid this clone if we had access to a mutable reference of state_storage on the BundleBuilder
quentinv72
commented
May 14, 2024
| bundle_builder = bundle_builder.revert_storage( | ||
| block_number, | ||
| address, | ||
| revert_storage.entry(block_and_address).or_default().clone(), |
There was a problem hiding this comment.
Same idea as above to avoid clone.
quentinv72
requested review from
rakita,
joshieDo,
shekhirin,
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
emhane
added
D-good-first-issue
emhane
requested changes
May 18, 2024
emhane
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4614
insert_stateincrates/node-core/src/init.rsto use BundleBuilderunwind_or_peek_stateincrates/storage/provider/src/providers/database/provider.rsto use BundleBuilderBundleStateInit,AccountRevertInit, andRevertInit.