Enabled two new CI workflows to build, test, (and release) containers.

[f0rki]

Test the nix and docker-based install methods.

• container-build.yml - does the docker magic
  • build a docker container with the default Dockerfile and check whether make ci-test works.
  • build a "release" container that is pushed to ghcr.io/papis/papis, i.e., papis packaged as a container.
    • this container is tested by running a couple of papis commands tools/run-integration-test.sh
• nix-flake.yml - does the nix magic
  • runs nix build - checks the flake build
  • runs nix develop - checks whether pytest passes in the nix development environment.

Packaging papis in docker is a nice thing to have and quite easy with github's container registry (ghcr.io). For example, if you like to run papis serve on your home server this might be a convenient thing to run.

[alexfikl]

Left a few questions, but overall this looks good to me!

Does this require some special access to publish the Docker images?

[alexfikl]

Why this change? The CI often fails on Windows but not Linux or on some python versions and not others, so it's very useful to let it all run.

[f0rki]

Ok I wanted to reduce redundant failures, e.g. because PRs forgot to format or because of some trailing whitespace. But I can remove that.

[alexfikl]

That's a fair point, but probably better handled by just separating the static checks (flake8, mypy) and only running pytest if those succeed.

papis tests are pretty fast, so we never bothered too much :\

[f0rki]

ok I separated them. Now the lints are run first on ubuntu-latest with latest python in a separate step before running all tests/lints with the matrix job.

[f0rki]

Yeah I think you have to enable that workflows can write to the repo/registry in the Settings.

[alexfikl]

I'm sorry for letting this fall off the radar for quite a while now. Maybe we can get some of it in!
From a quick skim:

1. I don't have access to add the required Docker permissions to make that workflow work, so that will have to wait.
2. Splitting the linting in the main CI doesn't sound like a good idea. Time-wise, the CI is pretty fast and the OS/version matrix takes the most time. Otherwise, it's better to pass linting on all versions we support so contributors can have a clean lint even if their system is not ubuntu-latest. WONTFIX
3. There are many unrelated fixes for various things in here (from ruff?). Linting fixes #649
4. The nix stuff is done. ci: add workflow for testing nix flake #647

3 and especially 4 can go in right away, but they will have to be in separate PRs, since I can't merge this wholesale. Do you have any time to work on these? If not, I can slowly cherry pick stuff and merge it.

[f0rki]

If not, I can slowly cherry pick stuff and merge it.

Yes feel free to cherry pick the commits you think are worth merging now.

[f0rki]

There are many unrelated fixes for various things in here (from ruff?).

Yes there is a commit (e9cb62b) that adds things from ruff --fix

[alexfikl]

@f0rki Squashed and rebased this to only contain the docker stuff, since everything else should be in main already.

@alejandrogallo According to @f0rki, this requires adding some permissions to the settings and maybe some other things before it can actually get automagically published to ghcr.io. I don't have access to do that, so whenever you get a chance it would be cool to get it in 😁

[alexfikl]

This seems to be currently failing: https://github.com/f0rki/papis/actions/runs/6040713352/job/16392121597 (possibly my bad :(

[f0rki]

rebased and pushed fixes. should work now again.