Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change the code formatter to Ruff #6756

Merged
merged 2 commits into from
May 18, 2024
Merged

Chore: Change the code formatter to Ruff #6756

merged 2 commits into from
May 18, 2024

Conversation

stumpylog
Copy link
Member

Proposed change

Pending the backend updates to remove black from the deps and double check the documentation.

I actually like how it formats the with better

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels May 17, 2024
@github-actions github-actions bot added the enhancement New feature label May 17, 2024
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume youre waiting on the deps one, happy to switch to ruff if you prefer, thanks for the continued attention to source code quality

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.19%. Comparing base (3facdef) to head (43f69f8).

Current head 43f69f8 differs from pull request most recent head d06de21

Please upload reports for the commit d06de21 to get more accurate results.

Files Patch % Lines
src/documents/views.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6756   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         436      436           
  Lines       17977    17977           
  Branches     1525     1433   -92     
=======================================
  Hits        17473    17473           
  Misses        504      504           
Flag Coverage Δ
backend 95.88% <87.50%> (ø)
frontend 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stumpylog stumpylog marked this pull request as ready for review May 18, 2024 02:20
@stumpylog stumpylog requested a review from a team as a code owner May 18, 2024 02:20
@stumpylog stumpylog enabled auto-merge (squash) May 18, 2024 02:20
@stumpylog stumpylog merged commit 622f624 into dev May 18, 2024
25 checks passed
@stumpylog stumpylog deleted the feature-ruff-format branch May 18, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants