Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RU locale #730

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated RU locale #730

wants to merge 2 commits into from

Conversation

WizMe-M
Copy link

@WizMe-M WizMe-M commented Nov 20, 2023

Hi, I've added new translations and fixed some of old ones. Glad to share this with you.

I ran npm ci, npm run format and npm test and all is good.


Прошу пользователей на русском просмотреть этот перевод и проверить, что он читабельный, не содержит ошибок, очепяток и логически верен

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

@WizMe-M
Copy link
Author

WizMe-M commented Nov 20, 2023

Issue #248

@MaKleSoft
Copy link
Collaborator

@WizMe-M Thank you for your contribution! Looks like one of the tests failed due to missing translation keys. Can you run npm run locale:extract and push the updated translation files please?

@WizMe-M
Copy link
Author

WizMe-M commented Nov 29, 2023

I'm sorry there is an error when I try to extract translation keys:

PS C:\Users\maxim\WebstormProjects\padloc-ru> npm run locale:extract

> [email protected] locale:extract
> lerna run extract --scope '@padloc/locale'

lerna notice cli v5.1.8
lerna notice filter including "@padloc/locale"
lerna info filter [ '@padloc/locale' ]
lerna info Executing command in 1 package: "npm run extract"
lerna ERR! npm run extract exited 1 in '@padloc/locale'
lerna ERR! npm run extract stdout:

> @padloc/[email protected] extract
> ts-node src/extract.ts ../*/src/**/*.ts ../*/src/*.ts

updating translation keys for language: de
lerna ERR! npm run extract stderr:
Error: ENOENT: no such file or directory, open 'C:\Users\maxim\WebstormProjects\padloc-ru\packages\*\src\**\*.ts'
    at readFileSync (node:fs:453:20)
    at C:\Users\maxim\WebstormProjects\padloc-ru\packages\locale\src\extract.ts:173:47
    at Array.map (<anonymous>)
    at fromSource (C:\Users\maxim\WebstormProjects\padloc-ru\packages\locale\src\extract.ts:172:29)
    at updateTranslation (C:\Users\maxim\WebstormProjects\padloc-ru\packages\locale\src\extract.ts:201:25)
    at main (C:\Users\maxim\WebstormProjects\padloc-ru\packages\locale\src\extract.ts:244:9)
    at Object.<anonymous> (C:\Users\maxim\WebstormProjects\padloc-ru\packages\locale\src\extract.ts:248:1)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module.m._compile (C:\Users\maxim\WebstormProjects\padloc-ru\packages\locale\node_modules\ts-node\src\index.ts:1295:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
lerna ERR! npm run extract exited 1 in '@padloc/locale'

@MaKleSoft
Copy link
Collaborator

Hm, that's strange. Could have something to do with the fact that you're on windows. I'll take a look when I get the chance. Thanks again for the translations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants