Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch translations & wordlist #711

Closed
wants to merge 7 commits into from
Closed

Conversation

SEPPDROID
Copy link

@SEPPDROID SEPPDROID commented Jun 23, 2023

Least i could to is create a dutch translation for padloc ;).

i later read the issue thread #248 and noticed that https://github.com/jhjacobs81 started on the dutch translations, sorry if i possibly interfered...

Wordlist is from opentaal under the licenses:
A. BSD (revised version):

see readme

README_nl_NL.txt

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2023

CLA assistant check
All committers have signed the CLA.

@MaKleSoft
Copy link
Collaborator

@SEPPDROID Thanks for your contribution! Unfortunately one of the tests failed, saying there are missing translations. Can you run npm run locale:extract and then add the missing translations? Thanks!

@SEPPDROID
Copy link
Author

SEPPDROID commented Oct 18, 2023

@SEPPDROID Thanks for your contribution! Unfortunately one of the tests failed, saying there are missing translations. Can you run npm run locale:extract and then add the missing translations? Thanks!

Thank you for pointing me into the right direction! sorry for the messy commits, i forgot i ran dev on my local machine and accidently added unnecessary lines.

should be good now, let me know if all is ok :)

@SEPPDROID
Copy link
Author

SEPPDROID commented Oct 21, 2023

ran locale, format & test and all seems to work for me. Same with a fresh clone from my fork.

Sorry for wasting your time.

@SEPPDROID SEPPDROID closed this Oct 21, 2023
@MaKleSoft
Copy link
Collaborator

@SEPPDROID Why did you close this? If you're struggling with the failing tests I can sort those out for you and merge this. Only with your permission of course.

@SEPPDROID
Copy link
Author

@SEPPDROID Why did you close this? If you're struggling with the failing tests I can sort those out for you and merge this. Only with your permission of course.

I ran a dev setup and fixed the issue after the first fail. Then ran all the tests on my system again with everything passing, yet the check test fails at translation. I'm lacking the knowledge and archived my repo for someone else to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants