Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Macedonian Translation #594

Merged
merged 11 commits into from
Sep 14, 2022
Merged

Added Macedonian Translation #594

merged 11 commits into from
Sep 14, 2022

Conversation

andrejdaskalov
Copy link
Contributor

Added mk locale. Let me know if there's any issues
Issue #248

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2022

CLA assistant check
All committers have signed the CLA.

@BrunoBernardino
Copy link
Contributor

Hi @andrejdaskalov thank you so much for making this contribution! I've noticed this didn't have some tests running for PRs coming from forks that would've caught a few discrepancies, so I'm preparing that here, and after it, you should be able to merge origin/main once more, run npm run locale:extract locally, and push that again.

@BrunoBernardino
Copy link
Contributor

Alright @andrejdaskalov can you please pull/merge/update origin/main once more, run npm run locale:extract, and then push?

@BrunoBernardino
Copy link
Contributor

@andrejdaskalov seems you still need to run npm run locale:extract in order to fix the translations file, before pushing. Let me know if you need any help with that.

@andrejdaskalov
Copy link
Contributor Author

@BrunoBernardino I ran npm run locale:extract but I noticed I have a few new keys in the file and a few missing ones. I'm guessing the command added them? I'm translating those right now, as the tests fail because of missing values.

@BrunoBernardino
Copy link
Contributor

@andrejdaskalov that command will add some new strings and might move around some translations. It should still pass with empty values, though (will show English in those cases).

@BrunoBernardino BrunoBernardino merged commit 5bfca19 into padloc:main Sep 14, 2022
@BrunoBernardino
Copy link
Contributor

Thank you so much @andrejdaskalov ! Are you on Twitter by any chance so @MaKleSoft can give you a public shout-out?

@andrejdaskalov
Copy link
Contributor Author

andrejdaskalov commented Sep 14, 2022

@BrunoBernardino It was my pleasure. And I just created a Twitter account, it's @ ADaskalov . Looking forward to contributing to Padloc more in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants