-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Italian translations #520
Italian translations #520
Conversation
Grazie mille @coluzziandrea ! I'll review it before the end of the week. |
Thank you so much, @coluzziandrea! Unfortunately I just realised that the translation files haven't been regenerated since the v4 release and are incredibly outdated (there are many more strings now an a lot have changed). We can still merge this but we'll likely have to retranslate a lot of this after regenerating the language files. |
@MaKleSoft no prob, I will be happy to help you with the new translations, too. |
["Confirm Membership", "Confermare l'adesione"], | ||
["Organization Invite", "Invito Organizzazione"], | ||
["Please wait for an admin to complete the process. You will be notified as soon as you receive access.", "Attendere che un amministratore completi il processo. Riceverai una notifica non appena riceverai l'accesso."], | ||
["Enter Confirmation Code", ""], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaKleSoft I haven't confirmed, but will this become an empty string, or pick up the English version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will default to the English version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that sorry 😅
["Successfully imported {0} items.", "{0} Elementi importati con successo."], | ||
["This invite has expired", "Questo invito è scaduto"], | ||
["Accepted", "Accettato"], | ||
["expires {0}", "Scade {0}"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've been lowercase.
["Email Address", "Indirizzo Email"], | ||
["Master Password", "Password Principale"], | ||
["Login", "Login"], | ||
["New to Padloc?", "Nuovo in Padlock?"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've been Nuovo in Padloc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
@BrunoBernardino FYI, I went ahead and merged this because the language files need to be updated, anyway. We can fix any translation issues in a separate PR. |
["WARNING: Weak Password", "ATTENZIONE: Password debole"], | ||
["To complete the account recovery process, please enter the confirmation code sent to your email address!", "Per completare il processo di recupero dell'account, inserisci il codice di conferma inviato al tuo indirizzo email!"], | ||
["Account recovery successful!", "Recupero account eseguito con successo!"], | ||
["Report Errors", "Report Errori"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have been Segnalari Errori
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a tricky one, because if we talk about the action to report, yes it's 'Segnala Errori', if instead is the report of errors like list of errors, then it can be like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification! This is about the action, as it shows as a title of the dialog to report the errors to Padloc, so I think it fits in the first option. Since it's also in the infinitive form "To Report", I think "Segnalari" might make more sense than "Segnala" (which is second person of the singular form, I believe), but I'll leave that up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explanation! So since it's the action, it is between 'Segnalare Errori' or 'Segnala Errori', the infinitive form (Segnalare) in general is a bit wierd when you use it on an action on the web. Indeed, all the actions on mobile & web apps that have this feature use the 2nd person
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Va bene!
["Downgrade", "Retrocedi"], | ||
["No Plan Selected", "Nessun piano selezionato"], | ||
["Unlimited", "Illimitato"], | ||
["{0} / Year", "{0} / Year"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've been {0} / Anno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work here @coluzziandrea thanks once more! I added some questions and suggestions which you can take in consideration once we re-generate the translations files.
@BrunoBernardino it was my pleasure to help! |
@coluzziandrea Ok, language files are updated if you want to give it another shot 😊 |
Added italian translation.
Linked to #248
Notice that my previous PR #519 was made by my other account so I can not sign the CLA, please do not consider that