Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force-logout older clients and reject any future requests #513

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaKleSoft
Copy link
Collaborator

This will effectively disable access for all clients < 4.0.0. Not happy about doing this but it's necessary to prevent further issues.

Copy link
Contributor

@BrunoBernardino BrunoBernardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to fix a couple of tests about the legacy UI and server, but looks good apart from that!

@BrunoBernardino
Copy link
Contributor

@MaKleSoft let me know if you'd like me to fix this.

@MaKleSoft
Copy link
Collaborator Author

@BrunoBernardino I decided to table this for now. Other than I though originally, use of the v3 client was not responsible for any data loss, so I think this would cause more trouble than it would prevent at this point. It might still make sense to do this later, though, so let's just keep this open for now.

@BrunoBernardino BrunoBernardino marked this pull request as draft August 2, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants