Debian fix multi-bonds #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these bonds don't have addresses assigned they must be `manual` not `static`. When we had the method as static we'd get an ifup error complaining about a missing address, something like: ``` Mar 21 15:47:04 mm-test-n3 systemd[1]: Starting networking.service - Raise network interfaces... Mar 21 15:47:04 mm-test-n3 ifup[3012]: ifup: missing required variable: address Mar 21 15:47:04 mm-test-n3 ifup[3012]: ifup: missing required configuration variables for interface bond1/inet Mar 21 15:47:04 mm-test-n3 ifup[3012]: ifup: failed to bring up bond1 ```
This way we get bonds, interfaces, resolvers, routes in a stable order since they are all now sorted. Not really necessary but a nice QoL for humans.
mmlb
force-pushed
the
deb-fix-bond1+-method
branch
from
ccc6faa
to
5d88d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonds 1+ need to be configured with method=manual instead of method=static since we do not have any static addresses to configure them with. I've also gone through and sorted all the loop'd stuff so that the e-n-i contents isn't random depending on metadata json and python internals.