feat(traverse): mutable access to scopes tree + symbol table

[overlookmotel]

Allow mutable access to scopes tree and symbol table.

Closes #3189.

This completes the v1 scopes-in-traverse implementation, and provides all the primitives required to implement the missing APIs listed in #3251.

Performance is abysmal, as noted in #3304, but we can fix that later on by taking Semantic out of the picture, or optimizing it.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• feat(traverse): mutable access to scopes tree + symbol table #3314 👈
• feat(traverse): pass &mut TraverseCtx to visitors #3312
• refactor(traverse): move parent method etc into TraverseAncestry #3308
• refactor(traverse): Traverse produce scopes tree using Semantic #3304
• refactor(semantic): semantic populate scope_id fields in AST #3303
• refactor(ast): store ScopeId in AST nodes #3302
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3314 will create unknown performance changes

_{Comparing 05-16-feat_traverse_mutable_access_to_scopes_tree_symbol_table (0c09047) with main (723a46f)}

Summary

🆕 27 new benchmarks

Benchmarks breakdown

	Benchmark	main	05-16-feat_traverse_mutable_access_to_scopes_tree_symbol_table	Change
🆕	codegen_sourcemap[react.development.js]	N/A	12.7 ms	N/A
🆕	codegen_sourcemap[typescript.js]	N/A	1.2 s	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	85.8 µs	N/A
🆕	lexer[antd.js]	N/A	107.8 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	26.7 ms	N/A
🆕	lexer[checker.ts]	N/A	63.6 ms	N/A
🆕	lexer[pdf.mjs]	N/A	17.6 ms	N/A
🆕	linter[cal.com.tsx]	N/A	2.9 s	N/A
🆕	linter[checker.ts]	N/A	5.3 s	N/A
🆕	minifier[react.development.js]	N/A	8.4 ms	N/A
🆕	minifier[typescript.js]	N/A	1.2 s	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	268.7 µs	N/A
🆕	parser[antd.js]	N/A	544.2 ms	N/A
🆕	parser[cal.com.tsx]	N/A	119.3 ms	N/A
🆕	parser[checker.ts]	N/A	277.7 ms	N/A
🆕	parser[pdf.mjs]	N/A	88.7 ms	N/A
🆕	semantic[RadixUIAdoptionSection.jsx]	N/A	415.3 µs	N/A
🆕	semantic[antd.js]	N/A	749.1 ms	N/A
🆕	semantic[cal.com.tsx]	N/A	219.8 ms	N/A
🆕	semantic[checker.ts]	N/A	556.1 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[overlookmotel]

OK, the stack is complete. Ready for review.

@rzvxa just to let you know...

@Boshen @Dunqing once this is merged, we have mutable scopes in the transformer, and everything we need to build all the missing APIs listed in #3251. 🍾

[graphite-app]

Merge activity

• May 16, 12:19 PM EDT: Boshen added this pull request to the Graphite merge queue.
• May 16, 12:34 PM EDT: Boshen merged this pull request with the Graphite merge queue.