Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ast): do not include trailing_comma in JSON AST #3073

Merged

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Apr 22, 2024

Don't include trailing_comma fields in JSON AST, for compat with ESTree (#2854).

@github-actions github-actions bot added the A-ast Area - AST label Apr 22, 2024
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Apr 22, 2024

CodSpeed Performance Report

Merging #3073 will not alter performance

Comparing 04-22-fix_ast_do_not_include_trailing_comma_in_JSON_AST (dee1290) with main (be9cdfc)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen merged commit 81f90fd into main Apr 22, 2024
31 checks passed
@Boshen Boshen deleted the 04-22-fix_ast_do_not_include_trailing_comma_in_JSON_AST branch April 22, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants