feat(linter/react): add the `rules_of_hooks` rule. #3071

rzvxa · 2024-04-22T12:14:48Z

RulesOfHooks, docs, npm
This one sounds like something straight out of Mortal Kombat!

rzvxa · 2024-04-22T12:15:03Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

codspeed-hq · 2024-04-22T12:20:38Z

CodSpeed Performance Report

Merging #3071 will not alter performance

_{Comparing 04-22-feat_linter_react_add_the_rules_of_hooks_rule (1f135ce) with main (d9e2431)}

Summary

✅ 27 untouched benchmarks

rzvxa · 2024-05-01T14:35:08Z

Status update:

This PR passes all react's official tests(even some that aren't passing in the original rule) there is only one situation that isn't detected... The labeled blocks with [labeled] breaks.

These don't have a correct cfg representation.

…fg. (#3122) I don't know if it is correct or not, Fixes my issues with dangling cfg nodes created in for statements. #3071

Boshen · 2024-05-10T14:15:32Z

@mysteryven Good luck reviewing this ... and take your time :-)

mysteryven

LGTM, learned something new, thanks!

crates/oxc_linter/src/rules/react/rules_of_hooks.rs

graphite-app · 2024-05-12T19:19:00Z

Merge activity

May 12, 3:19 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 12, 3:20 PM EDT: rzvxa added this pull request to the Graphite merge queue.
May 12, 3:24 PM EDT: rzvxa merged this pull request with the Graphite merge queue.

[RulesOfHooks](https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/src/RulesOfHooks.js), [docs](https://react.dev/reference/rules/rules-of-hooks), [npm](https://www.npmjs.com/package/eslint-plugin-react-hooks) This one sounds like something straight out of `Mortal Kombat`!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [oxlint](https://oxc-project.github.io) ([source](https://togithub.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.3.2` -> `0.3.5`](https://renovatebot.com/diffs/npm/oxlint/0.3.2/0.3.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/oxlint/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/oxlint/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/oxlint/0.3.2/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/oxlint/0.3.2/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oxc-project/oxc (oxlint)</summary> ### [`v0.3.5`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.5): oxlint v0.3.5 [Compare Source](https://togithub.com/oxc-project/oxc/compare/7193d75e9444ae8c2ba757b3bc64459abd0e128a...754d9f4c98aab052cf6b2756f7af12557042708d) #### What's Changed - feat(linter): add use-isnan fixer for (in)equality operations by [@DonIsaac](https://togithub.com/DonIsaac) in [oxc-project/oxc#3284 - feat(linter/eslint): Implement fixer for unicode-bom rule by [@jelly](https://togithub.com/jelly) in [oxc-project/oxc#3259 - fix(linter/no-direct-mutation-state): false positive when class is declared inside a `CallExpression` by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3294 - fix(parser): parse `DecoratorCallExpression` when `Arguments` contains `MemberExpression` by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3265 - perf(ast): inline all `ASTBuilder` methods by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3295 - perf(lexer): dedupe numeric separator check by [@DonIsaac](https://togithub.com/DonIsaac) in [oxc-project/oxc#3283 - perf(linter): rewrite react/require-render-return by [@mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3276 #### New Contributors - [@g-plane](https://togithub.com/g-plane) made their first contribution in [oxc-project/oxc#3268 **Full Changelog**: oxc-project/oxc@oxlint_v0.3.4...oxlint_v0.3.5 ### [`v0.3.4`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.4): oxlint v0.3.4 [Compare Source](https://togithub.com/oxc-project/oxc/compare/6149e49ef79a22004e36820c81afcb0c755fcc81...7193d75e9444ae8c2ba757b3bc64459abd0e128a) #### What's Changed - [feat(linter): move react/rules_of_hooks to nursery](https://togithub.com/oxc-project/oxc/commit/6edcae86cda8922ea8f9e5eae91290018e1b1637) - feat(linter/eslint): Implement max-classes-per-file by [@jelly](https://togithub.com/jelly) in [oxc-project/oxc#3241 - **Full Changelog**: oxc-project/oxc@oxlint_v0.3.3...oxlint_v0.3.4 *** ### From v0.3.3 #### What's Changed ##### Features - add `--symlinks` to allow symbolic walking by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3244 - add `--format github` for github check annotation by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3191 - change the category of all react-perf rules to perf by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3243 - remove deprecated eslint v9 rules `no-return-await` and `no-mixed-operators` by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3188 - move prefer-node-protocol to restriction by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3171 ##### New Rules - react/rules-of-hooks by [@rzvxa](https://togithub.com/rzvxa) in [oxc-project/oxc#3071 - eslint/radix by [@KubaJastrz](https://togithub.com/KubaJastrz) in [oxc-project/oxc#3167 - eslint/no-new-native-nonconstructor by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3187 - eslint/unicode-bom by [@jelly](https://togithub.com/jelly) in [oxc-project/oxc#3239 - eslint/no-empty-function rule by [@jelly](https://togithub.com/jelly) in [oxc-project/oxc#3181 - eslint-plugin-next/no-duplicate-head by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3174 - eslint-plugin-next/no-page-custom-font by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3185 - eslint-plugin-next/no-styled-jsx-in-document by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3184 - unicorn/no-anonymous-default-export by [@1zumii](https://togithub.com/1zumii) in [oxc-project/oxc#3220 ##### Bug Fixes - improve `prefer-string-starts-ends-with` rule by [@camc314](https://togithub.com/camc314) in [oxc-project/oxc#3176 - import/export: improve multiple exports error message by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3160 - import/named: handle `import { default as foo }` by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3255 - shorten eslint/eqeqeq rule error message's span by [@mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3193 - fix(parser): correctly parse cls.fn<C> = x by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3208 #### New Contributors - [@KubaJastrz](https://togithub.com/KubaJastrz) made their first contribution in [oxc-project/oxc#3167 - [@1zumii](https://togithub.com/1zumii) made their first contribution in [oxc-project/oxc#3220 **Full Changelog**: oxc-project/oxc@oxlint_v0.3.2...oxlint_v0.3.3 ### [`v0.3.3`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.3): oxlint v0.3.3 [Compare Source](https://togithub.com/oxc-project/oxc/compare/a7940868c6e66d16814ebef5c8dbbfd9b948a0cd...6149e49ef79a22004e36820c81afcb0c755fcc81) #### What's Changed ##### Features - add `--symlinks` to allow symbolic walking by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3244 - add `--format github` for github check annotation by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3191 - change the category of all react-perf rules to perf by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3243 - remove deprecated eslint v9 rules `no-return-await` and `no-mixed-operators` by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3188 - move prefer-node-protocol to restriction by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3171 ##### New Rules - react/rules-of-hooks by [@rzvxa](https://togithub.com/rzvxa) in [oxc-project/oxc#3071 - eslint/radix by [@KubaJastrz](https://togithub.com/KubaJastrz) in [oxc-project/oxc#3167 - eslint/no-new-native-nonconstructor by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3187 - eslint/unicode-bom by [@jelly](https://togithub.com/jelly) in [oxc-project/oxc#3239 - eslint/no-empty-function rule by [@jelly](https://togithub.com/jelly) in [oxc-project/oxc#3181 - eslint-plugin-next/no-duplicate-head by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3174 - eslint-plugin-next/no-page-custom-font by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3185 - eslint-plugin-next/no-styled-jsx-in-document by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3184 - unicorn/no-anonymous-default-export by [@1zumii](https://togithub.com/1zumii) in [oxc-project/oxc#3220 ##### Bug Fixes - improve `prefer-string-starts-ends-with` rule by [@camc314](https://togithub.com/camc314) in [oxc-project/oxc#3176 - import/export: improve multiple exports error message by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3160 - import/named: handle `import { default as foo }` by [@Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3255 - shorten eslint/eqeqeq rule error message's span by [@mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3193 - fix(parser): correctly parse cls.fn<C> = x by [@Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3208 #### New Contributors - [@KubaJastrz](https://togithub.com/KubaJastrz) made their first contribution in [oxc-project/oxc#3167 - [@1zumii](https://togithub.com/1zumii) made their first contribution in [oxc-project/oxc#3220 **Full Changelog**: oxc-project/oxc@oxlint_v0.3.2...oxlint_v0.3.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE).

…itional hooks. (#3299) related to #3071

github-actions bot added the A-linter Area - Linter label Apr 22, 2024

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from 968ce65 to 5804a32 Compare April 22, 2024 23:50

rzvxa changed the base branch from main to 04-23-feat_ast_add_callee_name_method_to_the_callexpression_ April 22, 2024 23:50

rzvxa mentioned this pull request Apr 22, 2024

feat(ast): add callee_name method to the CallExpression. #3076

Merged

Base automatically changed from 04-23-feat_ast_add_callee_name_method_to_the_callexpression_ to main April 23, 2024 01:47

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch 4 times, most recently from 7b0cfda to 78c9ba8 Compare April 28, 2024 20:20

rzvxa changed the base branch from main to 04-28-fix_connect_test_expression_of_for_statements_to_the_cfg April 28, 2024 20:20

rzvxa mentioned this pull request Apr 28, 2024

fix(semantic): connect test expression of for statements to the cfg. #3122

Merged

rzvxa force-pushed the 04-28-fix_connect_test_expression_of_for_statements_to_the_cfg branch from fef3ca3 to d24c226 Compare April 29, 2024 06:14

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from 35acd51 to a2fdc69 Compare April 29, 2024 06:14

rzvxa mentioned this pull request Apr 29, 2024

fix(semantic): add cfg nodes for ConditionalExpressions. #3127

Merged

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from a2fdc69 to b790ee0 Compare April 29, 2024 06:48

rzvxa changed the base branch from 04-28-fix_connect_test_expression_of_for_statements_to_the_cfg to 04-29-fix_semantic_add_cfg_nodes_for_conditionalexpression_s April 29, 2024 06:48

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from 99ffcd0 to 6d5706a Compare April 29, 2024 06:53

rzvxa mentioned this pull request May 1, 2024

feat(linter): stabilize no-barrel-file #3069

Closed

rzvxa force-pushed the 04-29-fix_semantic_add_cfg_nodes_for_conditionalexpression_s branch from 84f7348 to b76f2e0 Compare May 9, 2024 12:14

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from c5ad952 to 840eb52 Compare May 9, 2024 12:14

rzvxa mentioned this pull request May 10, 2024

improvement(semantic/cfg): add explicit break block element. #3223

Merged

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from 840eb52 to 1fa5287 Compare May 10, 2024 11:26

rzvxa changed the base branch from 04-29-fix_semantic_add_cfg_nodes_for_conditionalexpression_s to 05-10-improvement_semantic_add_explicit_break_block_element May 10, 2024 11:26

github-actions bot added the A-semantic Area - Semantic label May 10, 2024

rzvxa force-pushed the 05-10-improvement_semantic_add_explicit_break_block_element branch from ee83b4b to e3171a0 Compare May 10, 2024 12:53

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from d64d780 to 2cf4ee0 Compare May 10, 2024 12:53

rzvxa force-pushed the 05-10-improvement_semantic_add_explicit_break_block_element branch from e3171a0 to 0812788 Compare May 10, 2024 13:05

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from 2cf4ee0 to c59a2a2 Compare May 10, 2024 13:05

rzvxa marked this pull request as ready for review May 10, 2024 13:15

rzvxa requested a review from Boshen May 10, 2024 13:18

rzvxa marked this pull request as draft May 10, 2024 13:19

rzvxa removed the request for review from Boshen May 10, 2024 13:19

rzvxa marked this pull request as ready for review May 10, 2024 13:49

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from fcbb1dd to b0e22c1 Compare May 10, 2024 13:58

Boshen pushed a commit that referenced this pull request May 10, 2024

fix(semantic): connect test expression of for statements to the c…

c91d261

…fg. (#3122) I don't know if it is correct or not, Fixes my issues with dangling cfg nodes created in for statements. #3071

Boshen requested a review from mysteryven May 10, 2024 14:15

Boshen force-pushed the 05-10-improvement_semantic_add_explicit_break_block_element branch from 1a2657b to 7e78502 Compare May 10, 2024 14:17

Base automatically changed from 05-10-improvement_semantic_add_explicit_break_block_element to main May 10, 2024 14:22

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from b0e22c1 to beb07b8 Compare May 10, 2024 15:09

Boshen self-assigned this May 12, 2024

mysteryven approved these changes May 12, 2024

View reviewed changes

crates/oxc_linter/src/rules/react/rules_of_hooks.rs Outdated Show resolved Hide resolved

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from 75cd771 to 24171a9 Compare May 12, 2024 18:59

rzvxa added the merge label May 12, 2024

rzvxa force-pushed the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch from 33633ba to 1f135ce Compare May 12, 2024 19:20

graphite-app bot merged commit 1f135ce into main May 12, 2024
29 checks passed

graphite-app bot deleted the 04-22-feat_linter_react_add_the_rules_of_hooks_rule branch May 12, 2024 19:24

rzvxa mentioned this pull request May 16, 2024

fix(linter/react): rules_of_hooks resolve false positives with conditional hooks. #3299

Merged

Boshen pushed a commit that referenced this pull request May 16, 2024

fix(linter/react): rules_of_hooks resolve false positives with cond…

c8f1f79

…itional hooks. (#3299) related to #3071

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(linter/react): add the `rules_of_hooks` rule. #3071

feat(linter/react): add the `rules_of_hooks` rule. #3071

rzvxa commented Apr 22, 2024 •

edited

rzvxa commented Apr 22, 2024 •

edited

codspeed-hq bot commented Apr 22, 2024 •

edited

rzvxa commented May 1, 2024

Boshen commented May 10, 2024

mysteryven left a comment

graphite-app bot commented May 12, 2024 •

edited

feat(linter/react): add the rules_of_hooks rule. #3071

feat(linter/react): add the rules_of_hooks rule. #3071

Conversation

rzvxa commented Apr 22, 2024 • edited

rzvxa commented Apr 22, 2024 • edited

codspeed-hq bot commented Apr 22, 2024 • edited

CodSpeed Performance Report

Merging #3071 will not alter performance

Summary

rzvxa commented May 1, 2024

Status update:

Boshen commented May 10, 2024

mysteryven left a comment

Choose a reason for hiding this comment

graphite-app bot commented May 12, 2024 • edited

Merge activity

feat(linter/react): add the `rules_of_hooks` rule. #3071

feat(linter/react): add the `rules_of_hooks` rule. #3071

rzvxa commented Apr 22, 2024 •

edited

rzvxa commented Apr 22, 2024 •

edited

codspeed-hq bot commented Apr 22, 2024 •

edited

graphite-app bot commented May 12, 2024 •

edited