Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(semantic): incorrect reference flag for TSTypeParameter #2070

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(semantic): incorrect reference flag for TSTypeParameter #2070

wants to merge 1 commit into from
+119 −7

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 17, 2024 •
edited

fix: #2023

@Dunqing
Copy link
Member Author

Dunqing commented Jan 17, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST labels Jan 17, 2024
@Dunqing Dunqing marked this pull request as draft January 17, 2024 13:46
Dunqing
Dunqing commented Jan 17, 2024
View reviewed changes
crates/oxc_ast/src/visit.rs Outdated Show resolved Hide resolved
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 17, 2024 •
edited

CodSpeed Performance Report

Merging #2070 will not alter performance

Comparing 01-17-fix_semantic_incorrect_reference_flag_for_TSTypeParameter (4282891) with main (90f9266)

Summary

✅ 27 untouched benchmarks

@Dunqing Dunqing requested a review from Boshen January 17, 2024 15:01
@Dunqing Dunqing force-pushed the 01-17-fix_semantic_incorrect_reference_flag_for_TSTypeParameter branch 5 times, most recently from 51332ad to e700e7e Compare February 18, 2024 06:20
@Dunqing Dunqing force-pushed the 01-17-fix_semantic_incorrect_reference_flag_for_TSTypeParameter branch from e700e7e to 4282891 Compare February 18, 2024 06:50
@Dunqing
Copy link
Member Author

Dunqing commented Feb 18, 2024

I added SymbolFlags::TypeBlock for some ts blocks that need a scope. This seems to solve our problem, but I'm not sure if this is a good solution.

@Dunqing Dunqing marked this pull request as ready for review February 18, 2024 06:57
@Boshen
Copy link
Member

Boshen commented Feb 18, 2024

This feels dangerous 🤔

@Boshen Boshen marked this pull request as draft February 18, 2024 07:03
@Dunqing
Copy link
Member Author

Dunqing commented Feb 18, 2024

This feels dangerous 🤔

I think the main problem is adding a scope to the class declaration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
A-ast Area - AST A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect symbol references
2 participants
@Dunqing @Boshen