Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 (grapher) add a globe view / TAS-516 #3589

Draft
wants to merge 8 commits into
base: mobile-tooltips-fixed
Choose a base branch
from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented May 7, 2024

Merged from #3057

To do:

  • Choose a default projection (for when we can't detect the user's country); decided to go for an approach that rotates based on day light
  • Ike noticed a memory leak – after an hour or so, the page became unresponsive
  • Add Antarctica to the globe (by adding an entry in MapTopology.ts, see https://raw.githubusercontent.com/alexabruck/worldmap-sensitive/master/dist/world.topo.json) To be done at another time (after building a pipeline for our topology)
  • Always render globe toggle into the Settings popup

Default projection suggestion:
00:00 - 07:59 GMT - Asia & Oceania 🌏
08:00 - 15:59 GMT - Europe & Africa 🌍
16:00 - 23:59 GMT - Americas 🌎

Future work:

  • Pinch to zoom (for maps and the globe)

@owidbot
Copy link
Contributor

owidbot commented May 7, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-globe

SVG tester:

Number of differences (default views): 4130 (f92244) ❌
Number of differences (all views): 1663 (ba8007) ❌

Edited: 2024-06-12 12:00:48 UTC
Execution time: 1.28 seconds

@sophiamersmann sophiamersmann changed the title Add a globe view to Grapher 🎉 (grapher) add a globe view May 7, 2024
Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

Copy link
Member Author

sophiamersmann commented May 29, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@sophiamersmann sophiamersmann changed the title 🎉 (grapher) add a globe view 🎉 (grapher) add a globe view / TAS-516 Jun 3, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants