Consolidate use of errors #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcaamano
force-pushed
the
join-error
branch
3 times, most recently
from
2b36008
to
0569859
Compare
As follows: * Replaced all equivalent uses of github.com/pkg/errors for standard library errors * Replaced the uses of github.com/pkg/errors Wrapf for fmt.Errorf. The need for the stack trace that Wrapf brings seems arbitrary * Replaced the uses of the standard library errors Join, as well as k8s aggregate errors, with our own implementation which works similarly to standard library's but formats the concatenation as the k8s aggregate errors separating with commas rather than new lines which is an inconvenience. When compared to k8s aggregate errors, our implementation is simpler catering to our needs and complies fully with current wrapping mechanism whereas the former does not support 'errors.As' Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
tssurya
added
the
area/code-cleanup
| @@ -83,22 +81,22 @@ func getOvsPortBandwidth(ifname string, dir direction) (int64, error) { | |||
| func getInterfaceIngressBandwith(ifname string) (int64, error) { | |||
| qos_id, err := ovsGet("port", ifname, "qos", "") | |||
| if err != nil { | |||
| return 0, errors.Wrapf(err, "Failed to get qos for port %s", ifname) | |||
| return 0, fmt.Errorf("failed to get qos for port %s: %w", ifname, err) | |||
girishmg
approved these changes
Jun 4, 2024
|
I think this was a really nice cleanup, however unless we add some section here: https://ovn-kubernetes.io/developer-guide/developer/ for developers I get this feeling in no time we might go back to using different things in different spots. Just putting what's in the commit message under a sub heading is good enough for the docs, that way next time we can just point people to Best Practices or Coding Style for OVN-Kubernetes etc.. will be nice to have a section there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follows: