Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OVN to 24.03.2.5; Renable ANP Pass action logging for ACL #4367

Merged
merged 2 commits into from
May 28, 2024

Conversation

tssurya
Copy link
Member

@tssurya tssurya commented May 17, 2024

What this PR does and why is it needed

Brings in a fix from OVN for pass action logging for ANP

Which issue(s) this PR fixes

Fixes #

Special notes for reviewers

How to verify it

e2e tests exist

Details to documentation updates

Description for the changelog

Ensures pass-action ACL logging works correctly

Does this PR introduce a user-facing change?

YES

For more information on release notes see: TBD
-->

Fixes bug in pass-action ACL logging for ANP

@tssurya tssurya requested a review from a team as a code owner May 17, 2024 11:18
@tssurya tssurya requested a review from pperiyasamy May 17, 2024 11:18
@tssurya tssurya added kind/bug All issues that are bugs and PRs opened to fix bugs feature/admin-network-policy labels May 17, 2024
@tssurya
Copy link
Member Author

tssurya commented May 17, 2024

timed out conformance: https://github.com/ovn-org/ovn-kubernetes/actions/runs/9127393420/job/25098469320?pr=4367

Will run 346 of 7407 specs
Running in parallel across 10 processes
Error: The action 'Run Tests' has timed out after 120 minutes.

@tssurya
Copy link
Member Author

tssurya commented May 20, 2024

ehhhh;
investigating failures:

2024-05-17T13:19:50.2500388Z   May 17 13:19:50.249: INFO: Ensuring the audit log contains: 'name="ANP:harry-potter:Egress:2"', 'verdict=allow' AND 'severity=warning'
2024-05-17T13:19:50.3956731Z   �[38;5;9m[FAILED]�[0m in [It] - /home/runner/work/ovn-kubernetes/ovn-kubernetes/test/e2e/acl_logging.go:298 �[38;5;243m@ 05/17/24 13:19:50.394�[0m
2024-05-17T13:19:51.3473054Z   �[1mSTEP:�[0m deleting the admin network policy �[38;5;243m@ 05/17/24 13:19:51.346�[0m

Signed-off-by: Surya Seetharaman <[email protected]>
@tssurya
Copy link
Member Author

tssurya commented May 27, 2024

finally got around to doing this! updating the PR..

https://issues.redhat.com/browse/FDP-559 has been fixed.
Let's bump OVN and re-enabling those test bits

Signed-off-by: Surya Seetharaman <[email protected]>
@tssurya
Copy link
Member Author

tssurya commented May 27, 2024

@pperiyasamy : I have updated this PR, PTAL after CI passes, I think the e2es should be fixed now.

@coveralls
Copy link

Coverage Status

coverage: 52.55% (-0.04%) from 52.588%
when pulling 39d3e64 on tssurya:bump-ovn
into 03f117e on ovn-org:master.

@pperiyasamy
Copy link
Contributor

LGTM

@tssurya
Copy link
Member Author

tssurya commented May 28, 2024

since I am an approver I can merge lgtm-ed PRs :D

@tssurya tssurya merged commit 0fb7014 into ovn-org:master May 28, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/admin-network-policy kind/bug All issues that are bugs and PRs opened to fix bugs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants