Use ip mapped mac address for internal management port #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxiaobin
force-pushed
the
ip-mapped-mgmt-mac
branch
2 times, most recently
from
8767cb5
to
0a6bf14
Compare
jxiaobin
force-pushed
the
ip-mapped-mgmt-mac
branch
from
0a6bf14
to
827f895
Compare
|
Changes unknown |
jxiaobin
force-pushed
the
ip-mapped-mgmt-mac
branch
9 times, most recently
from
36e5a4d
to
860513b
Compare
jxiaobin
force-pushed
the
ip-mapped-mgmt-mac
branch
3 times, most recently
from
070fbe8
to
50dda6f
Compare
|
/lgtm |
|
flake in external-gateway lane which is not related to this PR: #4139 |
Currently a randomly generated MAC address will be assigned to the internal management interface, but in the case of dpu, the MAC will be derived from the IP of management interface, for example, IP 10.244.2.2 will be mapped to MAC `0a:58:0a:f4:02:02`. This commit makes both DPU and non-DPU cases to use IP derived MAC address for the management interface. Signed-off-by: Xiaobin Qu <[email protected]>
jxiaobin
force-pushed
the
ip-mapped-mgmt-mac
branch
from
50dda6f
to
7953a5f
Compare
github-actions
bot
added
the
area/unit-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
Currently for management port of internal type, a randomly generated MAC address will be used, while for dpu case, the IP of management port will be mapped to mac address which in turn will be assigned to the port.
This commit changes the behavior of internal management port to make it align with that of dpu backed management port.
Which issue(s) this PR fixes
None
Special notes for reviewers
None
How to verify it
Check mac address of interface
ovn-k8s-mp0, make sure it in the pattern of0a:58:mm:xx:yy:zz, where mm:xx:yy:zz is the hexadecimal form of management port's IP address.Details to documentation updates
None
Description for the changelog
For management port of internal type, generate MAC address by mapping its IP address to hexadecimal form.
Does this PR introduce a user-facing change?
No