helm, ipam, virt: allow persistent ips on helm based installations #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Duarte Barroso <[email protected]>
|
I still didn't test this locally since the kind-helm script depends on docker (I use podman ...). I'd still appreciate if you could point out something visibly broken. |
`docker build` is an alias for `docker buildx build`, which does not automatically load the generated images into `docker images` - for that, it needs to use the `--load` or `--output=type=docker` options. When explicitly doing `kind load docker-image`, the image must be available on docker images. Signed-off-by: Miguel Duarte Barroso <[email protected]>
tssurya
added
feature/multi-networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog