[WIP] Issue 1647 rendered banner poi #1735
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2020 19:24
- renders a banner using it's base color and the NBT data - supports rendering the backside, too - currently not used and only tested manually
Atten007
added a commit
to Atten007/Minecraft-Overviewer
that referenced
this pull request
Apr 12, 2022
Atten007
added a commit
to Atten007/Minecraft-Overviewer
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #1647
I have implemented code to render a banner using it's NBT data (see first commit).
When trying to use it from genPOI I have the following problems / questions:
Note: Because the render_banner function requires a Textures object placing the code in the filter itself would probably not work (no access to the config)
The second commit contains some of my thoughts (partially commented). Maybe you can help me with the questions above.
The config I used (including the Filters): config.txt
Example for the Banner Rendering:
