Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 3D Preview of the models #168

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TaylorMouse
Copy link

No description provided.

@ZingBallyhoo
Copy link
Member

ZingBallyhoo commented Dec 1, 2022

no guarantees we will take this, but if we were to we would first need

all style/reformat changes undone. just causes massive clutter
obj code moved out of teModelChunk_RenderMesh.cs. owmdl code is in its own file and this should be too
delete teTriangle and just make a basic triangle type internal to obj writer
obj files shouldn't be written to disk for tankview preview
some explaination of whatever's changed in tankview

maybe other devs can come up with more

@TaylorMouse
Copy link
Author

Oh, ok, I thought the comparison of git spoke for itself but here are the changes:

So to be able to render in 3D I used a nuget package called HelixToolkit & HelixToolkit.Core.Wpf. Which I referenced in the PreviewDataModel.xaml ( the one that said "Soon!" )
So I think that is the correct place.
Since this is for quick viewing I converted it to obj first, cuz that is a format the Helix3DViewport natively understands as a format.

In the MainWindow.xaml I added a button that allows the conversion of the selected objects to export to obj as well.

Since I didn't find a reference to a Tris or triangle I used the naming convention you guys use, hence the teTriangle.

I also made the gridsplitter more obvious cuz I found that it was confusing from a UX point of view, but you can always undo that.

In the GUID Collection I need to pass in the selected object or item ( value )

So I don't really understand the "clutter" you are refering to .

@ZingBallyhoo
Copy link
Member

ZingBallyhoo commented Dec 1, 2022

image
i mean dis. there is no code change here and other places in this file, just style

@TaylorMouse
Copy link
Author

Oh, sry about that, I sometimes press K + D for auto formatting the code, I might have pressed that by accident :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants